Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Pass in properties to Custom Socket Factory Constructor #1515

Open
shubha-rajan opened this issue Feb 10, 2021 · 1 comment
Labels
Enhancement An enhancement to the driver. Lower priority than bugs.

Comments

@shubha-rajan
Copy link

Is your feature request related to a problem? If so, please give a short summary of the problem and how the feature would resolve it

I'm one of the maintainers of the Cloud SQL Java Connector and my team is working on making improvements to the JDBC socket factory for SQL Server by allowing users to pass in more configuration options (for example, allowing them to specify connecting over Public or Private IP). In order to do this, we would need to pass in more than one argument to the SocketFactory constructor.

Describe the preferred solution

Instead of passing in a socketFactoryConstructorArg string to the SocketFactory constructor, give it access to all of the properties from the JDBC connection URL.

Reference Implementation

Example implementation from Postgres JDBC Driver: https://github.com/pgjdbc/pgjdbc/blob/01dbbac5b6c43e1079a463119e13c1bee74cbfdb/pgjdbc/src/main/java/org/postgresql/core/SocketFactoryFactory.java#L39

@shubha-rajan shubha-rajan added the Enhancement An enhancement to the driver. Lower priority than bugs. label Feb 10, 2021
@lilgreenbird
Copy link
Contributor

hi @shubha-rajan

Thank you for the suggestion, the team will consider this when we look into new features for the driver.

@github-project-automation github-project-automation bot moved this to To be triaged in MSSQL JDBC Aug 28, 2024
@Jeffery-Wasty Jeffery-Wasty moved this from To be triaged to Backlog in MSSQL JDBC Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement An enhancement to the driver. Lower priority than bugs.
Projects
Status: Backlog
Development

No branches or pull requests

2 participants