-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DatabaseMetaData.getDatabaseProductVersion should return the DB edition too. #1474
Comments
That sounds like a breach of contract https://docs.oracle.com/javase/8/docs/api/java/sql/DatabaseMetaData.html#getDatabaseProductVersion-- |
I would also rather expect the information about the edition to be returned by getDatabaseProductName, I have mentioned the other method only because in case of oracle it is returned by that method. According to my test none of the methods returns the database edition. Do you get the edition as part of getDatabaseProductName? |
but you've asked for a modification of as you can see in the code see also https://sqlhints.com/tag/sql-version-to-product-name-mapping/ |
I've asked for the modification of getDatabaseProductVersion because oracle is putting the edition information in there already, but I do agree that it should have been getDatabaseProductName all along. And yes, I already looked up getDatabaseProductName and noticed that it returns a hard coded string. In any case I would like to have the information about the DB edition, regardless of the method that returns it. |
Is the suggestion to return |
@ulvii Yes. |
Thanks @JSamir , we will look into this. |
Is your feature request related to a problem? If so, please give a short summary of the problem and how the feature would resolve it
We have some code that does different stuff depending on the DB being enterprise or standard edition. For oracle we can use getDatabaseProductVersion which returns the edition too, it would be good if sqlserver would to the same.
Describe the preferred solution
Have "Standard/Enterprise Edition" within the version string.
The text was updated successfully, but these errors were encountered: