Skip to content

Commit 17b3588

Browse files
committed
Code review adjustments
1 parent 2aa704c commit 17b3588

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

src/main/java/com/microsoft/sqlserver/jdbc/SQLServerCallableStatement.java

-6
Original file line numberDiff line numberDiff line change
@@ -2550,8 +2550,6 @@ public void registerOutParameter(String parameterName, int sqlType, String typeN
25502550
loggerExternal.entering(getClassNameLogging(), "registerOutParameter",
25512551
new Object[] {index, sqlType, typeName});
25522552

2553-
checkClosed();
2554-
25552553
registerOutParameterByName(index, sqlType);
25562554

25572555
loggerExternal.exiting(getClassNameLogging(), "registerOutParameter");
@@ -2570,8 +2568,6 @@ public void registerOutParameter(String parameterName, int sqlType, int scale) t
25702568
loggerExternal.entering(getClassNameLogging(), "registerOutParameter",
25712569
new Object[] {index, sqlType, scale});
25722570

2573-
checkClosed();
2574-
25752571
registerOutParameterByName(index, sqlType);
25762572
inOutParam[index - 1].setOutScale(scale);
25772573

@@ -2592,8 +2588,6 @@ public void registerOutParameter(String parameterName, int sqlType, int precisio
25922588
loggerExternal.entering(getClassNameLogging(), "registerOutParameter",
25932589
new Object[] {index, sqlType, scale, precision});
25942590

2595-
checkClosed();
2596-
25972591
registerOutParameterByName(index, sqlType);
25982592
inOutParam[index - 1].setValueLength(precision);
25992593
inOutParam[index - 1].setOutScale(scale);

src/main/java/com/microsoft/sqlserver/jdbc/SQLServerResource.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ protected Object[][] getContents() {
144144
{"R_stringNotInHex", "The string is not in a valid hex format."},
145145
{"R_unknownType", "The Java type {0} is not a supported type."},
146146
{"R_physicalConnectionIsClosed", "The physical connection is closed for this pooled connection."},
147-
{"R_noNamedAndIndexedParameters", "Detected uncompliant use of both named and indexed parameters while 'useFlexibleCallableStatements=false'. It is suggested to either exclusively use named parameters or indexed parameters."},
147+
{"R_noNamedAndIndexedParameters", "Cannot specify both named and indexed parameters when 'useFlexibleCallableStatements=false'"},
148148
{"R_unknownOutputParameter", "Cannot acquire output parameter value by name. No parameter index was associated with the output parameter name. If acquiring output parameter by name, verify that the output parameter was initially registered by name."},
149149
{"R_invalidDataSourceReference", "Invalid DataSource reference."},
150150
{"R_cantGetColumnValueFromDeletedRow", "Cannot get a value from a deleted row."},

src/test/java/com/microsoft/sqlserver/jdbc/TestResource.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ protected Object[][] getContents() {
5757
{"R_grantFailed", "grant table with preparedStatement failed!"},
5858
{"R_connectionIsClosed", "The connection is closed."},
5959
{"R_noNamedAndIndexedParameters",
60-
"Detected uncompliant use of both named and indexed parameters while 'useFlexibleCallableStatements=false'. It is suggested to either exclusively use named parameters or indexed parameters."},
60+
"Cannot specify both named and indexed parameters when 'useFlexibleCallableStatements=false'"},
6161
{"R_unknownOutputParameter",
6262
"Cannot acquire output parameter value by name. No parameter index was associated with the output parameter name. If acquiring output parameter by name, verify that the output parameter was initially registered by name."},
6363
{"R_ConnectionURLNull", "The connection URL is null."},

0 commit comments

Comments
 (0)