Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collectLocalReport util method requires "packages" base folder #61

Closed
benkeen opened this issue Apr 16, 2024 · 2 comments
Closed

collectLocalReport util method requires "packages" base folder #61

benkeen opened this issue Apr 16, 2024 · 2 comments

Comments

@benkeen
Copy link
Contributor

benkeen commented Apr 16, 2024

Hey @layershifter, would you be amenable to a PR to make "packages" folder here a configurable setting on CollectLocalReportOptions?

monosize/packages/monosize/src/utils/collectLocalReport.mts

Line 46 in 2db473d

reportFilesGlob: 'packages/**/dist/bundle-size/monosize.json',

Our monorepo uses Rush and has a differently-named base folder for our packages.
@layershifter
Copy link
Member

layershifter commented Apr 16, 2024 •
edited
Loading

That's already supported, but have not been documented. See #26

@benkeen
Copy link
Contributor Author

benkeen commented Apr 16, 2024

Excellent, thanks @layershifter!

@benkeen benkeen closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benkeen @layershifter