Relax the StartVM timeout

danmihai1 · Redent0r · commit 9cf648df79d6 · 2023-04-06T13:25:58.000-07:00
Signed-off-by: Dan Mihai &lt;dmihai@microsoft.com&gt;
diff --git a/src/runtime/virtcontainers/clh.go b/src/runtime/virtcontainers/clh.go
@@ -688,7 +688,9 @@ func (clh *cloudHypervisor) StartVM(ctx context.Context, timeout int) error {
 	}
 	clh.state.PID = pid
 
-	ctx, cancel := context.WithTimeout(ctx, clh.getClhAPITimeout()*time.Second)
+	// TODO: revisit the value of this timeout. It currently allows a slower guest VM startup.
+	// ctx, cancel := context.WithTimeout(context.Background(), clh.getClhAPITimeout()*time.Second)
+	ctx, cancel := context.WithTimeout(ctx, 10*time.Second)
 	defer cancel()
 
 	if err := clh.bootVM(ctx); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -688,7 +688,9 @@ func (clh *cloudHypervisor) StartVM(ctx context.Context, timeout int) error {`
`688`	`688`	`}`
`689`	`689`	`clh.state.PID = pid`
`690`	`690`
`691`		`- ctx, cancel := context.WithTimeout(ctx, clh.getClhAPITimeout()*time.Second)`
	`691`	`+ // TODO: revisit the value of this timeout. It currently allows a slower guest VM startup.`
	`692`	`+ // ctx, cancel := context.WithTimeout(context.Background(), clh.getClhAPITimeout()*time.Second)`
	`693`	`+ ctx, cancel := context.WithTimeout(ctx, 10*time.Second)`
`692`	`694`	`defer cancel()`
`693`	`695`
`694`	`696`	`if err := clh.bootVM(ctx); err != nil {`