-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in handling of images larger than around 1MB #1097
Comments
Looking |
I may have broken things when working with my 2gb videos. |
Try 101.0 |
Now working with 1.101.1. However initializing env with files (in my case 30 images each between 500kB and 2MB), before first prompt is sent, takes around 7 minutes with node process at 100% of one CPU core. During that time, in the GenAIScript tab in VS Code, I see files appearing one by one every 15 seconds or so. I do not recall any preprocessing delay, maybe at most a few seconds, last time I ran this script with same input files. |
Let me test this scenario. |
do you use defImages(env.files) in your script? |
I do a for loop on For example with test folder containing 30 images each between 500kB and 2MB:
|
Perfect thanks for the repro. I've started loading binary files and this might be the issue. Also it's possible that these images get processed by Jimp which can be slow as well. looking |
Oopsies, we were tokenizing the binary data in the trace. Back to instantly fast (until it hits the resizing step) |
@AlexandreBouffard try v1.101.2 |
@pelikhan fixed! |
I have a script that iterates over images to perform an inline prompt using
defImages()
.content
attribute is populated.Unsupported buffer-like object
inresolveBufferLike()
. Debugging shows that theircontent
attribute is missing.This script was working fine a few days/weeks ago, with same input files.
The text was updated successfully, but these errors were encountered: