Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Please make your examples accessible #56

Open
7mary4 opened this issue Mar 1, 2019 · 2 comments
Open

Please make your examples accessible #56

7mary4 opened this issue Mar 1, 2019 · 2 comments

Comments

@7mary4
Copy link

7mary4 commented Mar 1, 2019

This is a great course and people will use your examples as a best practice. Please ensure your examples are accessible. For instance, the first exercise has an input that depends on the placeholder attribute instead of a label.
<input class="textfield" placeholder="add todo">

Providing accessible examples will ensure the next generation of developers include it in their work.

@micahgodbolt
Copy link
Member

How do you feel this is not accessible? Narrator has no trouble reading the placeholder text. Adding aria-label would be redundant.

@flexbox
Copy link

flexbox commented Mar 4, 2019

@micahgodbolt placeholer are technicaly correct but for real life example they are not the best.
https://www.smashingmagazine.com/2018/06/placeholder-attribute/

I think @7mary4 wanted to add the classic label + input combo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants