diff --git a/change/@fluentui-react-conformance-431ee39f-6045-4fc2-92c0-ac5b7f5d9b6c.json b/change/@fluentui-react-conformance-431ee39f-6045-4fc2-92c0-ac5b7f5d9b6c.json new file mode 100644 index 0000000000000..4054763700368 --- /dev/null +++ b/change/@fluentui-react-conformance-431ee39f-6045-4fc2-92c0-ac5b7f5d9b6c.json @@ -0,0 +1,7 @@ +{ + "type": "minor", + "comment": "Deprecate consistent-callback-args test", + "packageName": "@fluentui/react-conformance", + "email": "yuanboxue@microsoft.com", + "dependentChangeType": "patch" +} diff --git a/packages/react-conformance/src/defaultTests.tsx b/packages/react-conformance/src/defaultTests.tsx index 1eb5d36d7013f..2c7f648dbc571 100644 --- a/packages/react-conformance/src/defaultTests.tsx +++ b/packages/react-conformance/src/defaultTests.tsx @@ -444,7 +444,10 @@ export const defaultTests: DefaultTestObject = { }); }, - /** Ensures that components have consistent callback arguments (ev, data) */ + /** + * Ensures that components have consistent callback arguments (ev, data) + * @deprecated this test is for existing callbacks. The newly added callbacks' type will be guarded by eslint rule consistent-callback-type + */ 'consistent-callback-args': (testInfo, componentInfo, tsProgram) => { it('has consistent custom callback arguments (consistent-callback-args)', () => { const { testOptions = {} } = testInfo; diff --git a/packages/react-conformance/src/types.ts b/packages/react-conformance/src/types.ts index 95ab76f99cd23..44668d74d817c 100644 --- a/packages/react-conformance/src/types.ts +++ b/packages/react-conformance/src/types.ts @@ -137,6 +137,9 @@ export interface DefaultTestObject { 'has-top-level-file': BaseConformanceTest; 'kebab-aria-attributes': ConformanceTest; 'consistent-callback-names': ConformanceTest; + /** + * @deprecated this test is for existing callbacks. The newly added callbacks' type will be guarded by eslint rule consistent-callback-type + */ 'consistent-callback-args': ConformanceTest; 'primary-slot-gets-native-props': BaseConformanceTest; }