Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify hover card as per design #28617

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Modify hover card as per design #28617

wants to merge 6 commits into from

Conversation

krkshitij
Copy link
Contributor

@krkshitij krkshitij commented Jul 23, 2023 •
edited
Loading

Previous Behavior

Single Single without legend Single without x value, but with ratio and description Multi with max width Group Column

New Behavior

Single Single in long legend variant Single without legend Single without x value, but with ratio and description Multi with max width Multi with max width in long legend variant Group Group in long legend variant Column

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 23, 2023 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 88bd423b47995eca9a23a8438405d55626be9ebf

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 23, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6db1724:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Jul 23, 2023 •
edited
Loading

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 325743f

Possible causes

  • The baseline build 325743f is broken
  • The Size Auditor run for the baseline build 325743f was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@krkshitij krkshitij marked this pull request as ready for review July 27, 2023 06:24
@krkshitij krkshitij requested a review from a team as a code owner July 27, 2023 06:24
@krkshitij krkshitij requested a review from AtishayMsft August 1, 2023 07:37
AtishayMsft
AtishayMsft reviewed Aug 23, 2023
View reviewed changes
packages/react-charting/src/utilities/ChartHoverCard/ChartHoverCard.styles.ts
backgroundBlendMode: 'normal, luminosity',
},
],
calloutContentRoot: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found out that single callout is showing the left color border as white in high contrast mode. Because the forcedColorAdjust high contrast selector is not set.
But it is set for multi value callout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AtishayMsft AtishayMsft AtishayMsft left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@AtishayMsft AtishayMsft

Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krkshitij @fabricteam @AtishayMsft