fix: TooltipHost supports an accessible method to implement overflow tooltips #27653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 738c2fd:
|
Asset size changes
Baseline commit: 46f19b90d2088f055f9cd4bfad840f72fe68f0d8 (build) |
📊 Bundle size report🤖 This report was generated against 46f19b90d2088f055f9cd4bfad840f72fe68f0d8 |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 780 | 792 | 5000 | |
| Breadcrumb | mount | 2077 | 2049 | 1000 | |
| Checkbox | mount | 2100 | 2097 | 5000 | |
| CheckboxBase | mount | 1846 | 1853 | 5000 | |
| ChoiceGroup | mount | 3486 | 3503 | 5000 | |
| ComboBox | mount | 786 | 798 | 1000 | |
| CommandBar | mount | 7757 | 7703 | 1000 | |
| ContextualMenu | mount | 13084 | 13721 | 1000 | |
| DefaultButton | mount | 944 | 932 | 5000 | |
| DetailsRow | mount | 2637 | 2635 | 5000 | |
| DetailsRowFast | mount | 2626 | 2622 | 5000 | |
| DetailsRowNoStyles | mount | 2456 | 2423 | 5000 | |
| Dialog | mount | 3222 | 3219 | 1000 | |
| DocumentCardTitle | mount | 287 | 292 | 1000 | |
| Dropdown | mount | 2445 | 2473 | 5000 | |
| FocusTrapZone | mount | 1397 | 1403 | 5000 | |
| FocusZone | mount | 1361 | 1363 | 5000 | |
| GroupedList | mount | 45369 | 45388 | 2 | |
| GroupedList | virtual-rerender | 22090 | 22110 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 62353 | 62283 | 2 | |
| GroupedListV2 | mount | 292 | 284 | 2 | |
| GroupedListV2 | virtual-rerender | 265 | 263 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 286 | 289 | 2 | |
| IconButton | mount | 1318 | 1303 | 5000 | |
| Label | mount | 444 | 452 | 5000 | |
| Layer | mount | 3350 | 3386 | 5000 | |
| Link | mount | 521 | 525 | 5000 | |
| MenuButton | mount | 1169 | 1149 | 5000 | |
| MessageBar | mount | 25853 | 26301 | 5000 | |
| Nav | mount | 2362 | 2350 | 1000 | |
| OverflowSet | mount | 1028 | 1012 | 5000 | |
| Panel | mount | 2181 | 2168 | 1000 | |
| Persona | mount | 914 | 925 | 1000 | |
| Pivot | mount | 1058 | 1068 | 1000 | |
| PrimaryButton | mount | 1040 | 1039 | 5000 | |
| Rating | mount | 5767 | 5752 | 5000 | |
| SearchBox | mount | 1096 | 1126 | 5000 | |
| Shimmer | mount | 2371 | 2314 | 5000 | |
| Slider | mount | 1693 | 1685 | 5000 | |
| SpinButton | mount | 3391 | 3400 | 5000 | |
| Spinner | mount | 509 | 519 | 5000 | |
| SplitButton | mount | 2178 | 2158 | 5000 | |
| Stack | mount | 536 | 530 | 5000 | |
| StackWithIntrinsicChildren | mount | 1084 | 1071 | 5000 | |
| StackWithTextChildren | mount | 3363 | 3392 | 5000 | |
| SwatchColorPicker | mount | 7326 | 7348 | 5000 | |
| TagPicker | mount | 1708 | 1704 | 5000 | |
| Text | mount | 488 | 490 | 5000 | |
| TextField | mount | 1131 | 1118 | 5000 | |
| ThemeProvider | mount | 1014 | 1006 | 5000 | |
| ThemeProvider | virtual-rerender | 793 | 794 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1571 | 1550 | 5000 | |
| Toggle | mount | 794 | 773 | 5000 | |
| buttonNative | mount | 244 | 248 | 5000 |
change/@fluentui-react-4d88449d-bf95-4d68-97d6-aac8295938bf.json
Outdated
Show resolved
Hide resolved
sopranopillow
approved these changes
Apr 27, 2023
Co-authored-by: Esteban Munoz Facusse <[email protected]>
fabricteam
reviewed
Apr 29, 2023
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots
✅ There was 0 screenshots added, 2 screenshots removed, 1045 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.
unknown 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Pivot - Overflow.Root.Narrow - Last tab selected.chromium.png | 0 | Removed |
| Pivot - Overflow.Root.Narrow - Overflow menu.chromium.png | 0 | Removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
TooltipHost has an
overflowModefeature that lets authors automatically show a tooltip with the specified element has text oveflow. The issue is that the element must be either:Neither of those options support allowing a focusable semantic element to have an overflow tooltip that shows up on focus. All possible overflow tooltip options only supported hover.
New Behavior
TooltipHost now has a
TooltipOverflowMode.Customoption, and a prop to pass in a ref to the element that should be used for overflow calculations. This allows authors to target a child interactive element, which then works to trigger a tooltip on keyboard focus.The examples for overflowMode have also been updated, and the incorrect information about
aria-describedbyhas been removed.Related Issue(s)
This came up while trying to help a team implement a keyboard-accessible overflow tooltip on a link.