Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#24280 issueFixed: focus is not set on first item #27412

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

GAUARVCHIT
Copy link

Fixed the issue. Now focus should be on first item.

New Behavior

Related Issue(s)

Fixed the issue. Now focus should be on first item.
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 2, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit aacc94e:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 2, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8c1140461454f55359a4d329f376e8f5bc401e02 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 2, 2023

📊 Bundle size report

🤖 This report was generated against 8c1140461454f55359a4d329f376e8f5bc401e02

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 2, 2023

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 2, 2023

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 929 924 5000
Breadcrumb mount 2150 2172 1000
Checkbox mount 2184 2206 5000
CheckboxBase mount 1937 1936 5000
ChoiceGroup mount 3627 3684 5000
ComboBox mount 939 938 1000
CommandBar mount 7876 7881 1000
ContextualMenu mount 12514 12846 1000
DefaultButton mount 1085 1086 5000
DetailsRow mount 2768 2751 5000
DetailsRowFast mount 2770 2776 5000
DetailsRowNoStyles mount 2594 2598 5000
Dialog mount 3131 3090 1000
DocumentCardTitle mount 430 435 1000
Dropdown mount 2623 2608 5000
FocusTrapZone mount 1542 1553 5000
FocusZone mount 1517 1479 5000
GroupedList mount 45969 52720 2
GroupedList virtual-rerender 22514 22343 2
GroupedList virtual-rerender-with-unmount 62939 63329 2
GroupedListV2 mount 415 426 2
GroupedListV2 virtual-rerender 399 399 2
GroupedListV2 virtual-rerender-with-unmount 420 411 2
IconButton mount 1480 1502 5000
Label mount 569 587 5000
Layer mount 3527 3456 5000
Link mount 663 661 5000
MenuButton mount 1301 1318 5000
MessageBar mount 25876 25871 5000
Nav mount 2494 2495 1000
OverflowSet mount 1145 1135 5000
Panel mount 2052 2077 1000
Persona mount 1042 1081 1000
Pivot mount 1193 1215 1000
PrimaryButton mount 1193 1191 5000
Rating mount 5789 5867 5000
SearchBox mount 1218 1237 5000
Shimmer mount 2399 2399 5000
Slider mount 1755 1754 5000
SpinButton mount 3547 3551 5000
Spinner mount 628 634 5000
SplitButton mount 2368 2370 5000
Stack mount 664 661 5000
StackWithIntrinsicChildren mount 1217 1201 5000
StackWithTextChildren mount 3572 3527 5000
SwatchColorPicker mount 7554 7666 5000
TagPicker mount 1910 1854 5000
Text mount 624 629 5000
TextField mount 1265 1250 5000
ThemeProvider mount 1116 1123 5000
ThemeProvider virtual-rerender 896 935 5000
ThemeProvider virtual-rerender-with-unmount 1638 1646 5000
Toggle mount 911 885 5000
buttonNative mount 376 378 5000

@spmonahan
Copy link
Contributor

@GAUARVCHIT You need to generate change files for this PR by running yarn change.

@microsoft-github-policy-service

@GAUARVCHIT please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@GAUARVCHIT
Copy link
Author

@GAUARVCHIT You need to generate change files for this PR by running yarn change.

I appreciate your assistance. I have executed the command 'yarn change' and kindly inform me if any outstanding issues persist.

@GAUARVCHIT
Copy link
Author

@GAUARVCHIT please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Dropdown in panel - focus is not set on first item
5 participants