fix the decision condition in dismissOnTargetWindowBlur to handle the… #26930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… case that clicking inside an iframe.
Asset size changes
Baseline commit: bc7e2d2fea8c193acb3228b4aff6497ec3ceb029 (build) |
fabricteam
reviewed
Feb 21, 2023
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots
✅ There was 2 screenshots added, 0 screenshots removed, 1043 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.
unknown 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Pivot - Overflow.Tabs - RTL.Narrow - Last tab selected.chromium.png | 0 | Added |
| Pivot - Overflow.Tabs - RTL.Narrow - Overflow menu.chromium.png | 0 | Added |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 275725c:
|
📊 Bundle size report🤖 This report was generated against bc7e2d2fea8c193acb3228b4aff6497ec3ceb029 |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1182 | 1167 | 5000 | |
| Breadcrumb | mount | 2957 | 2884 | 1000 | |
| Checkbox | mount | 2556 | 2629 | 5000 | |
| CheckboxBase | mount | 2333 | 2246 | 5000 | |
| ChoiceGroup | mount | 4357 | 4413 | 5000 | |
| ComboBox | mount | 1207 | 1255 | 1000 | |
| CommandBar | mount | 9421 | 9189 | 1000 | |
| ContextualMenu | mount | 13639 | 13780 | 1000 | |
| DefaultButton | mount | 1359 | 1399 | 5000 | |
| DetailsRow | mount | 3317 | 3370 | 5000 | |
| DetailsRowFast | mount | 3482 | 3447 | 5000 | |
| DetailsRowNoStyles | mount | 3291 | 3122 | 5000 | |
| Dialog | mount | 3082 | 2970 | 1000 | |
| DocumentCardTitle | mount | 581 | 563 | 1000 | |
| Dropdown | mount | 3198 | 3156 | 5000 | |
| FocusTrapZone | mount | 1925 | 2021 | 5000 | |
| FocusZone | mount | 1956 | 1980 | 5000 | |
| GroupedList | mount | 51808 | 58688 | 2 | |
| GroupedList | virtual-rerender | 23918 | 24378 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 90909 | 91470 | 2 | |
| GroupedListV2 | mount | 528 | 568 | 2 | |
| GroupedListV2 | virtual-rerender | 531 | 531 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 554 | 575 | 2 | |
| IconButton | mount | 1908 | 1813 | 5000 | |
| Label | mount | 727 | 729 | 5000 | |
| Layer | mount | 4271 | 4329 | 5000 | |
| Link | mount | 827 | 833 | 5000 | |
| MenuButton | mount | 1638 | 1690 | 5000 | |
| MessageBar | mount | 2379 | 2323 | 5000 | |
| Nav | mount | 3282 | 3267 | 1000 | |
| OverflowSet | mount | 1363 | 1383 | 5000 | |
| Panel | mount | 2516 | 2567 | 1000 | |
| Persona | mount | 1296 | 1325 | 1000 | |
| Pivot | mount | 1647 | 1639 | 1000 | |
| PrimaryButton | mount | 1513 | 1507 | 5000 | |
| Rating | mount | 7007 | 6997 | 5000 | |
| SearchBox | mount | 1518 | 1506 | 5000 | |
| Shimmer | mount | 2831 | 2838 | 5000 | |
| Slider | mount | 2101 | 2088 | 5000 | |
| SpinButton | mount | 4640 | 4672 | 5000 | |
| Spinner | mount | 804 | 797 | 5000 | |
| SplitButton | mount | 3106 | 3099 | 5000 | |
| Stack | mount | 824 | 827 | 5000 | |
| StackWithIntrinsicChildren | mount | 2330 | 2323 | 5000 | |
| StackWithTextChildren | mount | 4776 | 4769 | 5000 | |
| SwatchColorPicker | mount | 10480 | 10528 | 5000 | |
| TagPicker | mount | 2646 | 2705 | 5000 | |
| TeachingBubble | mount | 84940 | 84989 | 5000 | |
| Text | mount | 790 | 797 | 5000 | |
| TextField | mount | 1637 | 1612 | 5000 | |
| ThemeProvider | mount | 1508 | 1513 | 5000 | |
| ThemeProvider | virtual-rerender | 1081 | 1086 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2165 | 2139 | 5000 | |
| Toggle | mount | 1114 | 1109 | 5000 | |
| buttonNative | mount | 530 | 545 | 5000 |
This was referenced Feb 22, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… case that clicking inside an iframe.
Previous Behavior
When clicking inside an iframe (but outside of the callout), the callout is not dismissed.
New Behavior
When clicking outside the callout, the onDismiss handler should be triggered, and the callout should disappear.
Related Issue(s)
#26927