chore: enable package.json prettier plugin and apply consistent style on whole monorepo #26827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ca896d8:
|
Asset size changes
Baseline commit: 4c323e21d84381804fc746f68affe7071adf83d6 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProvider | mount | 1672 | 2911 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1330 | 1339 | 5000 | |
| Button | mount | 961 | 971 | 5000 | |
| Field | mount | 2090 | 2103 | 5000 | |
| FluentProvider | mount | 1672 | 2911 | 5000 | Possible regression |
| FluentProviderWithTheme | mount | 637 | 642 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 1709 | 596 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 640 | 647 | 10 | |
| InfoButton | mount | 564 | 570 | 5000 | |
| MakeStyles | mount | 1921 | 1942 | 50000 | |
| Persona | mount | 3082 | 3025 | 5000 | |
| SpinButton | mount | 2802 | 2540 | 5000 |
fabricteam
reviewed
Feb 13, 2023
| @@ -1,23 +1,17 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots
✅ There was 0 screenshots added, 2 screenshots removed, 1043 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.
unknown 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Pivot - Overflow.Root.Narrow - Last tab selected.chromium.png | 0 | Removed |
| Pivot - Overflow.Root.Narrow - Overflow menu.chromium.png | 0 | Removed |
Perf Analysis (
|
🕵 fluentuiv9 No visual regressions between this PR and main |
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1207 | 1176 | 5000 | |
| Breadcrumb | mount | 2967 | 2995 | 1000 | |
| Checkbox | mount | 2641 | 2659 | 5000 | |
| CheckboxBase | mount | 2333 | 2345 | 5000 | |
| ChoiceGroup | mount | 4444 | 4488 | 5000 | |
| ComboBox | mount | 1249 | 1292 | 1000 | |
| CommandBar | mount | 10343 | 9711 | 1000 | |
| ContextualMenu | mount | 14564 | 14782 | 1000 | |
| DefaultButton | mount | 3769 | 1366 | 5000 | |
| DetailsRow | mount | 3478 | 3457 | 5000 | |
| DetailsRowFast | mount | 3481 | 3456 | 5000 | |
| DetailsRowNoStyles | mount | 3340 | 3309 | 5000 | |
| Dialog | mount | 3093 | 3109 | 1000 | |
| DocumentCardTitle | mount | 577 | 580 | 1000 | |
| Dropdown | mount | 3225 | 3233 | 5000 | |
| FocusTrapZone | mount | 2036 | 2054 | 5000 | |
| FocusZone | mount | 1990 | 1991 | 5000 | |
| GroupedList | mount | 1928 | 2170 | 2 | |
| GroupedList | virtual-rerender | 2003 | 1150 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 1658 | 1644 | 2 | |
| GroupedListV2 | mount | 574 | 578 | 2 | |
| GroupedListV2 | virtual-rerender | 546 | 546 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 556 | 568 | 2 | |
| IconButton | mount | 1931 | 1910 | 5000 | |
| Label | mount | 730 | 720 | 5000 | |
| Layer | mount | 4334 | 4344 | 5000 | |
| Link | mount | 837 | 825 | 5000 | |
| MenuButton | mount | 1687 | 1655 | 5000 | |
| MessageBar | mount | 2317 | 2351 | 5000 | |
| Nav | mount | 3252 | 3296 | 1000 | |
| OverflowSet | mount | 1368 | 1356 | 5000 | |
| Panel | mount | 2549 | 2570 | 1000 | |
| Persona | mount | 1320 | 1298 | 1000 | |
| Pivot | mount | 1633 | 1610 | 1000 | |
| PrimaryButton | mount | 1539 | 1527 | 5000 | |
| Rating | mount | 6999 | 7000 | 5000 | |
| SearchBox | mount | 1509 | 1514 | 5000 | |
| Shimmer | mount | 2915 | 2862 | 5000 | |
| Slider | mount | 2094 | 2086 | 5000 | |
| SpinButton | mount | 4716 | 4694 | 5000 | |
| Spinner | mount | 788 | 801 | 5000 | |
| SplitButton | mount | 3104 | 3089 | 5000 | |
| Stack | mount | 828 | 840 | 5000 | |
| StackWithIntrinsicChildren | mount | 2290 | 2287 | 5000 | |
| StackWithTextChildren | mount | 4722 | 4757 | 5000 | |
| SwatchColorPicker | mount | 10528 | 10434 | 5000 | |
| TagPicker | mount | 2642 | 2623 | 5000 | |
| TeachingBubble | mount | 92965 | 90751 | 5000 | |
| Text | mount | 798 | 809 | 5000 | |
| TextField | mount | 1592 | 1591 | 5000 | |
| ThemeProvider | mount | 1512 | 1543 | 5000 | |
| ThemeProvider | virtual-rerender | 1092 | 1074 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2148 | 2175 | 5000 | |
| Toggle | mount | 1083 | 1120 | 5000 | |
| buttonNative | mount | 533 | 547 | 5000 |
fabricteam
reviewed
Feb 13, 2023
| @@ -1,23 +1,17 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵 FluentUI-v0 Open the Visual Regressions report to inspect the 3 screenshots
✅ There was 0 screenshots added, 0 screenshots removed, 1257 screenshots unchanged, 0 screenshots with different dimensions and 3 screenshots with visible difference.
unknown 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Card.Card Example Context Menu.chromium.png | 16562 | Changed |
| Card.Card Example Expandable.chromium.png | 17227 | Changed |
| Card.Card Example Selectable Grid.chromium.png | 113007 | Changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
see related issues
New Behavior
Related Issue(s)
🚨 NOTE: This PR is blocked as the plugin references node natives via
node:protocol, which doesn't work in jest 26 jestjs/jest#11331BLOCKED BY #18442