Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: imporvements to how accordion attaches events to accordion item #33794

Open
2 tasks done
eljefe223 opened this issue Feb 6, 2025 · 0 comments
Open
2 tasks done

Comments

@eljefe223
Copy link
Contributor

Component

Accordion

Package version

3.0.0-beta.63

@microsoft/fast-element version

2.0.0

Environment

System:
    OS: macOS 15.2
    CPU: (12) arm64 Apple M2 Max
    Memory: 220.31 MB / 32.00 GB
    Shell: 3.2.57 - /bin/bash
  Browsers:
    Chrome: 132.0.6834.160
    Edge: 132.0.2957.140
    Safari: 18.2

Current Behavior

Accordion could be imporved. Currently the setItems call removes and adds events to this.children but its already using and tracking slottedAccordionItems.

Expected Behavior

Consider rewriting setItems and how accordion attaches and removes events from accordion-items

Reproduction

No reproduction just code imporvements

Steps to reproduce

No reproduction just code imporvements

Are you reporting an Accessibility issue?

None

Suggested severity

Low - Has or doesn't need a workaround

Products/sites affected

No response

Are you willing to submit a PR to fix?

yes

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant