You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Accordion could be imporved. Currently the setItems call removes and adds events to this.children but its already using and tracking slottedAccordionItems.
Expected Behavior
Consider rewriting setItems and how accordion attaches and removes events from accordion-items
Reproduction
No reproduction just code imporvements
Steps to reproduce
No reproduction just code imporvements
Are you reporting an Accessibility issue?
None
Suggested severity
Low - Has or doesn't need a workaround
Products/sites affected
No response
Are you willing to submit a PR to fix?
yes
Validations
Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
The provided reproduction is a minimal reproducible example of the bug.
The text was updated successfully, but these errors were encountered:
Component
Accordion
Package version
3.0.0-beta.63
@microsoft/fast-element version
2.0.0
Environment
Current Behavior
Accordion could be imporved. Currently the
setItems
call removes and adds events tothis.children
but its already using and trackingslottedAccordionItems
.Expected Behavior
Consider rewriting
setItems
and how accordion attaches and removes events fromaccordion-items
Reproduction
No reproduction just code imporvements
Steps to reproduce
No reproduction just code imporvements
Are you reporting an Accessibility issue?
None
Suggested severity
Low - Has or doesn't need a workaround
Products/sites affected
No response
Are you willing to submit a PR to fix?
yes
Validations
The text was updated successfully, but these errors were encountered: