Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable selective running of conformance tests that don't require TS info #28950

Closed
YuanboXue-Amber opened this issue Aug 22, 2023 · 3 comments · Fixed by #28988
Closed

Enable selective running of conformance tests that don't require TS info #28950

YuanboXue-Amber opened this issue Aug 22, 2023 · 3 comments · Fixed by #28988
Assignees

Comments

@YuanboXue-Amber
Copy link
Contributor

Some tests in @fluentui/react-conformance are for typings and requires ts.createProgram. However this can lead to JS out of memory error when @fluentui/react-conformance is used in a large repo. We build re-usable components in a large repo following fluent standard, but we face OOM error and can't run conformance tests.
Can we build ts program only when we need to run the tests that need it? This way we can run most of the conformance tests in our large repo.

@sopranopillow

This comment was marked as off-topic.

@YuanboXue-Amber
Copy link
Contributor Author

I'll use this issue as tracking issue for myself to add an option in react-conformance to run test that does not need TS.
Long-term we probably want to revisit react-conformance instead of just patching options. I'll discuss this with the team and create a new issue if needed.

@Hotell
Copy link
Contributor

Hotell commented Sep 21, 2023

can you provide examples facing OOM errors ? we mitigated and drastically improved conformance test type execution by implementing #27664

Can we build ts program only when we need to run the tests that need it?

this is great optimization indeed and something that was planned as well. could you please next time bring these topics to v-build syncs ?

in general whole conformance DX isn't the most ergonomic with its current api design as it posses lots of limitations. You can learn more what's planned for future in this epic #27359

ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants