Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Api extractor output does not match ci #28084

Closed
2 tasks done
sopranopillow opened this issue May 31, 2023 · 3 comments · Fixed by #28215
Closed
2 tasks done

[Bug]: Api extractor output does not match ci #28084

sopranopillow opened this issue May 31, 2023 · 3 comments · Fixed by #28215

Comments

@sopranopillow
Copy link
Contributor

Library

React Components / v9 (@fluentui/react-components)

System Info

System:
    OS: Linux 5.15 Ubuntu 20.04 LTS (Focal Fossa)
    CPU: (20) x64 Intel(R) Core(TM) i9-10900K CPU @ 3.70GHz
    Memory: 51.01 GB / 62.66 GB
    Container: Yes
    Shell: 5.8 - /usr/bin/zsh
  Browsers:
    Chrome: 113.0.5672.126
    Firefox: 104.0

Are you reporting Accessibility issue?

no

Reproduction

Cloning the repo and running yarn buildci gives a bunch of api changes.

Bug Description

Actual Behavior

Getting many api changes:
image

After talking to @TristanWatanabe, he mentioned this is due to a recent PR #27936 that bumps api-extractor. This bump included this change:

image

therefore our current way of dealing with path aliases is not working correctly:

image

From this, we get a removal of the following due to the api extractor not giving the same output as ci (also the local output is wrong)

image

Expected Behavior

CI and local api extractor should provide the same output.

Logs

No response

Requested priority

High

Products/sites affected

No response

Are you willing to submit a PR to fix?

yes

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@TristanWatanabe
Copy link
Member

TristanWatanabe commented May 31, 2023

For extra context, I believe this was the PR introduced in @microsoft/api-extractor version 7.21.0 that changed the behavior with how TS path aliases are handled: microsoft/rushstack#3321

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #28215, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #28215, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants