Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: yarn is not following yarn.lock for hoisting - webpack duplicates #27017

Closed
2 tasks done
Hotell opened this issue Mar 1, 2023 · 1 comment
Closed
2 tasks done
Labels
Area: Typescript dependencies Pull requests that update a dependency file Resolution: Won't Fix Not going to fix an issue due to various factors

Comments

@Hotell
Copy link
Contributor

Hotell commented Mar 1, 2023

Library

not applicable

System Info

not applicable

Are you reporting Accessibility issue?

no

Reproduction

Looks like yarn is not following yarn.lock.

This causes type mismatches and unexpected TS errors.

Bug Description

Discovered in this PR #26928

Actual Behavior

webpack 5 and all its dependencies are duplicated within particular @types/*/node_modules family of packages

yarn.lock excerpt:
yarn.lock excerpt

@types package not hoisting its dependencies:
@types package not hoisting its dependencies

Packages that contain webpack dupes:

Expected Behavior

yarn should hoist webpack to root, thus not creating types dupes that are causing issues

Logs

No response

Requested priority

Normal

Products/sites affected

fluent infra

Are you willing to submit a PR to fix?

yes

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@Hotell
Copy link
Contributor Author

Hotell commented Mar 1, 2023

looks like problem was between keyboard and monitor....

I somehow didn't see this one :)
image

@Hotell Hotell added Resolution: Won't Fix Not going to fix an issue due to various factors and removed Needs: Triage 🔍 labels Mar 1, 2023
@Hotell Hotell closed this as completed Mar 1, 2023
@microsoft microsoft locked as resolved and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Typescript dependencies Pull requests that update a dependency file Resolution: Won't Fix Not going to fix an issue due to various factors
Projects
None yet
Development

No branches or pull requests

2 participants