Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: griffel babel preset fails on SWC commonjs transpiled output #26251

Closed
2 tasks done
Hotell opened this issue Jan 9, 2023 · 10 comments
Closed
2 tasks done

[Bug]: griffel babel preset fails on SWC commonjs transpiled output #26251

Hotell opened this issue Jan 9, 2023 · 10 comments
Labels
Area: Build System Area: JS Styling Fluent UI react-components (v9) Resolution: Soft Close Soft closing inactive issues over a certain period Resolution: Won't Fix Not going to fix an issue due to various factors Type: Bug 🐛

Comments

@Hotell
Copy link
Contributor

Hotell commented Jan 9, 2023

Library

React Components / v9 (@fluentui/react-components)

Are you reporting Accessibility issue?

None

Reproduction

  1. checkout this branch https://github.com/hotell/fluentui/tree/use-swc-for-transpilation
  2. run yarn
  3. run node ./debug-swc

NOTE: the debug-swc script runs pipeline react-text dep tree for simplicity

Bug Description

We are in the process of migrating our transpilation pipelines from ts to swc for speed, but most importantly to start adhering to our browser matrix for transpiled code (#26170)

Actual Behavior

Griffel babel plugin cannot process commonjs output produced by swc

MicrosoftTeams-image (1)

Expected Behavior

Griffel babel plugin can process swc CJS output

Logs

No response

Requested priority

High

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@Hotell
Copy link
Contributor Author

Hotell commented Jan 9, 2023

This is caused by Linaria v3. V4 fixes this.

griffel uses v3 ATM migration to linaria v4 would need a lot of effort probably.

@microsoft-github-policy-service

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@microsoft-github-policy-service

Because this reported issue has not had any activity for over 180 days, we're automatically closing it for house-keeping reasons.

Still require assistance? Please, create a new issue with up-to date details and latest version of Fluent.

@microsoft-github-policy-service

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@microsoft-github-policy-service

Because this reported issue has not had any activity for over 180 days, we're automatically closing it for house-keeping reasons.

Still require assistance? Please, create a new issue with up-to date details and latest version of Fluent.

@microsoft-github-policy-service

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@microsoft-github-policy-service

Because this reported issue has not had any activity for over 180 days, we're automatically closing it for house-keeping reasons.

Still require assistance? Please, create a new issue with up-to date details and latest version of Fluent.

@Hotell Hotell reopened this Mar 6, 2024
@Hotell Hotell removed the Resolution: Soft Close Soft closing inactive issues over a certain period label Mar 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Sep 2, 2024

This issue has not had activity for over 180 days! We're adding Soft close label and will close it soon for house-keeping purposes.
Still require assistance? Please add comment - "keep open".

Because this reported issue has not had any activity for over 180 days, we're automatically closing it for house-keeping reasons.

Still require assistance? Please, create a new issue with up-to date details and latest version of Fluent.

@Hotell
Copy link
Contributor Author

Hotell commented Sep 3, 2024

This will probably never get fixed in griffel itself as the transition to linaria v4 is huge effort and provides worse performance.

We plan to remove griffel postprocessing from library code that we ship in future so this can be closed as "wont fix".

@Hotell Hotell added the Resolution: Won't Fix Not going to fix an issue due to various factors label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Build System Area: JS Styling Fluent UI react-components (v9) Resolution: Soft Close Soft closing inactive issues over a certain period Resolution: Won't Fix Not going to fix an issue due to various factors Type: Bug 🐛
Projects
None yet
Development

No branches or pull requests

3 participants