-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: createFocusOutlineStyle "focus-within" does not work after upgrade from v9.1.1 to v9.2.0 #25668
Comments
The problem here is that the We should export the fluentui/packages/react-components/react-tabster/src/hooks/useFocusWithin.ts Lines 5 to 10 in 64090fd
|
@ling1726 thank you for your quick response on this issue. I should pay more attention to the changelogs / release notes Lol. I notice that Also, will there be any plan to add those APIs in doc page? Thank you ^_^ |
yeah, the fact that it is not exported is a bug and I'll keep this issue open until we fix that :) |
FYI: I created a PR to re-export |
Library
React Components / v9 (@fluentui/react-components)
System Info
Are you reporting Accessibility issue?
no
Reproduction
https://codesandbox.io/s/thirsty-moon-p01443?file=/index.tsx
Bug Description
Actual Behavior
If change the @fluentui/react-components version to v9.2.0, build and run, tab to focus the link, cannot see the outline style
Expected Behavior
If change the @fluentui/react-components version to v9.1.1, build and run, tab to focus the link, can see the outline style
From version 9.1.1 to 9.2, I notice the @fluentui/react-tabster version goes from v9.0.3 to v9.1.0. Maybe some changes in @fluentui/react-tabster or its dependency tabster?
(Note: it does not matter if I use li or div as parent)
Any help is really appreciated.
Logs
No response
Requested priority
High
Products/sites affected
No response
Are you willing to submit a PR to fix?
yes
Validations
The text was updated successfully, but these errors were encountered: