Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of focus selectors in v9 #24183

Closed
3 tasks done
ling1726 opened this issue Aug 2, 2022 · 18 comments
Closed
3 tasks done

Improve performance of focus selectors in v9 #24183

ling1726 opened this issue Aug 2, 2022 · 18 comments
Assignees
Labels
Fluent UI react-components (v9) Resolution: Soft Close Soft closing inactive issues over a certain period Status: Blocked Resolution blocked by another issue

Comments

@ling1726
Copy link
Member

ling1726 commented Aug 2, 2022

The current data-keyboard-nav selector that is applied to the FluentProvider causes too much style recalclation each time the user's navigation mode changes (mouse/keyboard).

Below are results of the SelectorStats trace from edge://tracing which measures the time spent per-selector during the matching phase. The comparison was done by comparing selector stats for .fui-focus-visible (polyfill) vs the current [data-keyboard-nav] selector.

(Lower numbers are better)

[data-keyboard-nav] on provider root

time elapsed fast reject count match attempts match count
2098 1120 23511 416

Tasks

@ling1726
Copy link
Member Author

Blocked by: microsoft/keyborg#19

@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Feb 24, 2023
@ling1726 ling1726 reopened this Feb 24, 2023
@microsoft-github-policy-service

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

1 similar comment
@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

1 similar comment
@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

11 similar comments
@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as resolved.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI react-components (v9) Resolution: Soft Close Soft closing inactive issues over a certain period Status: Blocked Resolution blocked by another issue
Projects
None yet
Development

No branches or pull requests

3 participants