Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tools): introduce generic generator for various repo checks #22332

Open
3 tasks
Hotell opened this issue Apr 5, 2022 · 6 comments
Open
3 tasks

feat(tools): introduce generic generator for various repo checks #22332

Hotell opened this issue Apr 5, 2022 · 6 comments
Assignees
Labels
Area: Build System Resolution: Soft Close Soft closing inactive issues over a certain period Type: Epic

Comments

@Hotell
Copy link
Contributor

Hotell commented Apr 5, 2022

Story 🧚‍♀️

Currently we don't have a common way how to write various local/CI checks, so we don't put repo into invalid state by accident.

Idea is to create pluggable solution with tests that we have confidence that things work.

The solution will be implemented as a pluggable nx generator

API proposal

nx workspace-generator validate-repo --codeowners --pr-size=30 --workspace

where:

  • validate-repo name of generator
  • pluggable behaviour via flags (NOTE: contrived flags)
    • --codeowners boolean flag that will run codeowners setup check
    • --pr-size=30 configurable flag that will run PR size check and will break CI if user changed more than 30 files

tasks

Related issues

@Hotell Hotell self-assigned this Apr 5, 2022
@Hotell Hotell added this to the April Project Cycle Q1 2022 milestone Apr 5, 2022
@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Oct 2, 2022
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@Hotell Hotell reopened this Oct 3, 2022
@Hotell Hotell removed the Resolution: Soft Close Soft closing inactive issues over a certain period label Oct 18, 2022
@Hotell Hotell changed the title tools: introduce generic generator for various repo checks feat(tools): introduce generic generator for various repo checks Nov 1, 2022
@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label May 1, 2023
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@microsoft-github-policy-service

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@microsoft-github-policy-service

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@Hotell Hotell reopened this Oct 31, 2023

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@Hotell
Copy link
Contributor Author

Hotell commented Oct 15, 2024

nx shipped new core feature that will help us achieve these things in official way via generators

https://nx.dev/concepts/sync-generators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Build System Resolution: Soft Close Soft closing inactive issues over a certain period Type: Epic
Projects
None yet
Development

No branches or pull requests

2 participants