Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Classname Conformance Test Refactor #22117

Closed
spmonahan opened this issue Mar 15, 2022 · 2 comments
Closed

Static Classname Conformance Test Refactor #22117

spmonahan opened this issue Mar 15, 2022 · 2 comments
Assignees
Labels
Resolution: Soft Close Soft closing inactive issues over a certain period

Comments

@spmonahan
Copy link
Contributor

Consider refactoring the static class name tests from #21960 (see also #21847).

Possible updates:

  1. For expectedClassnames only require the slot names, not the mapped slot: classname object. This is less code and slightly cleaner.
  2. Consider removing the test the verifies that exported class names are in the correct format. This can be accomplished with (or similar)
export type SlotClassNames<Component, Slots> = {
  [SlotName in keyof Slots]-?: SlotName extends 'root'
    ? `fui-${string & Component}`
    : `fui-${string & Component}__${string & SlotName}`;
};

but requires the Template Literal Types feature from Typescript 4.1. react-components currently must support TS3.9.

Depends on

  1. Port react-conformance tests to testing-library #22009
  2. Rewrite react-conformance API to be more extensible/modular #21665
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Aug 20, 2022
@spmonahan spmonahan reopened this Aug 30, 2022
@spmonahan spmonahan removed the Resolution: Soft Close Soft closing inactive issues over a certain period label Aug 30, 2022
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Jan 27, 2023
@microsoft microsoft locked as resolved and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Soft Close Soft closing inactive issues over a certain period
Projects
None yet
Development

No branches or pull requests

3 participants