-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conformance tests for triggers #21670
Comments
This is needed as there are tests which are already copy&paste. |
Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
This issue has not had activity for over 180 days! We're adding Soft close label and will close it soon for house-keeping purposes. |
Recently we had various discussions around triggers and reached the agreement on how it should work:
child.props
always win, it is user's responsibility to handle itAnother point that we could cover that contract with conformance tests and enable them for components that use the trigger pattern. For an initial implementation the following scenarios should be covered.
Props merging
Props specified by a customer always win.
This should render following markup:
Callback merging
Internal and user's callbacks should be merged.
onClick
handler inTrigger
should be called if presentonClick
specified by user should be also calledThe text was updated successfully, but these errors were encountered: