Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converged Popover: nested popover is not updating position on scrolling container #21457

Open
YuanboXue-Amber opened this issue Jan 26, 2022 · 7 comments
Labels

Comments

@YuanboXue-Amber
Copy link
Contributor

YuanboXue-Amber commented Jan 26, 2022

Environment Information

  • Package version(s): (fill this out)
  • Browser and OS versions: (fill this out if relevant)

Please provide a reproduction of the bug in a codepen:

codesandbox: https://codesandbox.io/s/sad-haze-mzy63?file=/example.tsx

Actual behavior:

When scrolling the contaner (green box), the nested popover element is not updating its position to follow trigger:
Screenshot 2022-01-26 at 16 35 46

This happens because the trigger is rendered outside of the scroll container, so popperjs is not able to identify the scroll container as the trigger's scrollable parent: floating-ui/floating-ui#1267

Expected behavior:

In @fluentui/react-northstar, we had the similar issue. It was solved by adding a prop to dismiss popover on scrolling the container element (PR #21453 ).

Priorities and help requested:

Are you willing to submit a PR to fix? (Yes, No) no

Requested priority: (Blocking, High, Normal, Low) low

Products/sites affected: (if applicable)

@JustSlone
Copy link
Collaborator

We should fix this issue; I would love a better solution than a prop to dismiss on scrolling if we have that option.
Moving over to the new unified board and assigning to @microsoft/teams-prg

@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Feb 9, 2023
@layershifter layershifter reopened this Feb 9, 2023
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@layershifter layershifter reopened this Jul 10, 2023
@layershifter layershifter removed the Resolution: Soft Close Soft closing inactive issues over a certain period label Jul 10, 2023

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Dec 7, 2023
@layershifter layershifter reopened this Dec 7, 2023
@layershifter layershifter removed the Resolution: Soft Close Soft closing inactive issues over a certain period label Dec 7, 2023

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label May 6, 2024
@layershifter layershifter reopened this May 7, 2024
@layershifter layershifter removed the Resolution: Soft Close Soft closing inactive issues over a certain period label May 7, 2024

This issue has not had activity for over 180 days! We're adding Soft close label and will close it soon for house-keeping purposes.
Still require assistance? Please add comment - "keep open".

@microsoft-github-policy-service microsoft-github-policy-service bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Nov 4, 2024
@layershifter
Copy link
Member

keep open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants