Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Typescript 4.4+ #20942

Closed
ecraig12345 opened this issue Dec 7, 2021 · 11 comments · Fixed by #27936
Closed

Upgrade to Typescript 4.4+ #20942

ecraig12345 opened this issue Dec 7, 2021 · 11 comments · Fixed by #27936

Comments

@ecraig12345
Copy link
Member

According to TS team, 4.4 has "some big perf wins." 4.5 is current as of writing, but we should probably try 4.4 first.

@chrisdholt
Copy link
Member

We won't be able to move the Web Components to Typescript v4.4 as part of this due to an issue where lib-dom ARIAMixin value typings changed from string | null to string, essentially making these "non-nullable", which is problematic. This problem was initially raised here: microsoft/TypeScript#45047 and can be seen in the table denoting that a trivial fix is not available for this.

On the heels of this, the Typescript team quickly has provided a feature as of v4.5.0 which allows teams to pin lib-dom versions, which would enable stability between minor versions and allow us to move ahead. Without that, we'll hit build errors due to the typing incompatibilities noted above.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Jun 5, 2022
@ecraig12345 ecraig12345 removed the Resolution: Soft Close Soft closing inactive issues over a certain period label Jun 6, 2022
@ecraig12345 ecraig12345 reopened this Jun 6, 2022
@microsoft microsoft deleted a comment from msft-fluent-ui-bot Jun 6, 2022
@chrisdholt
Copy link
Member

We won't be able to move the Web Components to Typescript v4.4 as part of this due to an issue where lib-dom ARIAMixin value typings changed from string | null to string, essentially making these "non-nullable", which is problematic. This problem was initially raised here: microsoft/TypeScript#45047 and can be seen in the table denoting that a trivial fix is not available for this.

On the heels of this, the Typescript team quickly has provided a feature as of v4.5.0 which allows teams to pin lib-dom versions, which would enable stability between minor versions and allow us to move ahead. Without that, we'll hit build errors due to the typing incompatibilities noted above.

We’ve resolved this - FYI, so we can upgrade any time!

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Dec 3, 2022
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@khmakoto khmakoto reopened this Dec 5, 2022
@khmakoto khmakoto removed the Resolution: Soft Close Soft closing inactive issues over a certain period label Dec 5, 2022
@msft-fluent-ui-bot msft-fluent-ui-bot added Status: Fixed Fixed in some PR and removed Status: In PR labels May 30, 2023
@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #27936, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #27936, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #27936, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #27936, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #27936, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #27936, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #27936, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #27936, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@microsoft microsoft locked as resolved and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants