Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't run Storybook or e2e tests on CI with packages that aren't direct dependencies of react-components #20772

Closed
ling1726 opened this issue Nov 25, 2021 · 1 comment
Closed

Can't run Storybook or e2e tests on CI with packages that aren't direct dependencies of react-components #20772

ling1726 opened this issue Nov 25, 2021 · 1 comment
Labels
Area: Build System Resolution: Soft Close Soft closing inactive issues over a certain period Storybook

Comments

@ling1726
Copy link
Member

Discovered in #20756

since packages like react-tabster are not exported with the react-components suite package, its storybook is never deployed on CI. The react-components storybook is configured to load the stories of its direct dependencies. Therefore any package that wants to implement browser e2e tests will not be able to run them on CI if they are not a direct dependency of react-components.

This is the case even if solutions like #20223 proposed in an earlier RFC
@ling1726 ling1726 mentioned this issue Nov 25, 2021
Merged
2 tasks
@layershifter layershifter changed the title Can't run storyboob or e2e tests on CI with packages that aren't direct dependencies of react-components Can't run Storybook or e2e tests on CI with packages that aren't direct dependencies of react-components Nov 25, 2021
@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label May 24, 2022
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@microsoft microsoft locked as resolved and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Area: Build System Resolution: Soft Close Soft closing inactive issues over a certain period Storybook
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ling1726 @msft-fluent-ui-bot