Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add @ts-ignore removal from stories to migrate-converged-pkg #20560

Closed
Tracked by #19866
Hotell opened this issue Nov 9, 2021 · 1 comment
Closed
Tracked by #19866

tools: add @ts-ignore removal from stories to migrate-converged-pkg #20560

Hotell opened this issue Nov 9, 2021 · 1 comment

Comments

@Hotell
Copy link
Contributor

Hotell commented Nov 9, 2021

Follows #20478

Actual behavior:

  • converged package stories contain @ts-ignore pragmas if they import other monorepo packages
    • type checking doesn't work
@filename packages/react-menu/example.stories.tsx

// https://github.com/microsoft/fluentui/pull/18695#issuecomment-868432982
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
import { Button } from '@fluentui/react-button';

Expected behavior:

After package has been migrated to solution TS config all @ts-ignore pragmas should be removed, thus enabling proper DX and CI type checks within stories

@filename packages/react-menu/example.stories.tsx

-// https://github.com/microsoft/fluentui/pull/18695#issuecomment-868432982
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore
import { Button } from '@fluentui/react-button';
@Hotell Hotell changed the title tools: add @ts-ignore removal from stories migrate-converged-pkg tools: add @ts-ignore removal from stories to migrate-converged-pkg Nov 9, 2021
@khmakoto khmakoto assigned Hotell and unassigned khmakoto Nov 9, 2021
@Hotell
Copy link
Contributor Author

Hotell commented Nov 11, 2021

Closed by #20575

@Hotell Hotell closed this as completed Nov 11, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators Dec 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants