Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BasePicker breaks if null is returned from promise in onItemSelected #19746

Closed
SPWizard01 opened this issue Sep 10, 2021 · 1 comment · May be fixed by #19747
Closed

BasePicker breaks if null is returned from promise in onItemSelected #19746

SPWizard01 opened this issue Sep 10, 2021 · 1 comment · May be fixed by #19747
Assignees
@GeoffCoxMSFT
Labels
Resolution: Soft Close Soft closing inactive issues over a certain period Status: In PR

Comments

@SPWizard01
Copy link

Environment Information

  • Package version(s): 8.32.0
  • Browser and OS versions: Latest Edge, Win10

Please provide a reproduction of the bug in a codepen: https://codepen.io/spwizard01/pen/zYzZXam?editors=0010

Line 67

Actual behavior:

It will throw an error and break the UI if null is returned inside a promise.
Now you have to actually throw inside promise instead to avoid UI breaks

fluentui/packages/react/src/components/pickers/BasePicker.tsx

Line 807 in 3dbb57b

const newItems: T[] = this.state.items.concat([resolvedProcessedItem]);

Expected behavior:

It should not allow items being added as per documentation

Priorities and help requested:

Are you willing to submit a PR to fix? Yes

Requested priority: Normal

Products/sites affected: N/A
@SPWizard01 SPWizard01 mentioned this issue Sep 10, 2021
Open
1 task
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Jul 7, 2022
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@GeoffCoxMSFT GeoffCoxMSFT

Labels
Resolution: Soft Close Soft closing inactive issues over a certain period Status: In PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add null handling returned from promise inside BasePicker SPWizard01/fluentui
4 participants
@SPWizard01 @GeoffCoxMSFT @msft-fluent-ui-bot @gouttierre