-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-conformance: find a way to have typed "testOptions" with "extraTests" #19618
Comments
FYI @ecraig12345 |
@layershifter Good catch, do you have ideas for how to extend this, or a different approach? |
Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Per @layershifter's suggestion I'm planning on changing the isConformant API to be more like babel's API: isConformant({
componentPath: '',
presets: [ // or "rules"
basePreset({ /* strictly typed config options */ }),
griffelPreset(),
],
}); Each preset will also support an |
Tracked by #21665 instead. |
#19500 introduced new test conformance test, but it's used as extra test:
This works nice, but there is a small problem. The test has custom options (
callCount
) and they cannot be specified (produces TS error) as they no way to extendTestOption
type:fluentui/packages/react-conformance/src/types.ts
Lines 11 to 15 in 7d1896d
The text was updated successfully, but these errors were encountered: