Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: format/order particular type of files automatically #19561

Open
Hotell opened this issue Aug 30, 2021 · 13 comments
Open

tools: format/order particular type of files automatically #19561

Hotell opened this issue Aug 30, 2021 · 13 comments
Labels
Area: Build System Resolution: Soft Close Soft closing inactive issues over a certain period

Comments

@Hotell
Copy link
Contributor

Hotell commented Aug 30, 2021

nx is properly re-ordering/formatting tsconfig.json.base#paths, nx.json, workspace.json after any kind of generator is invoked that creates/updates/removes a package to maintain consistency and to reduce merge conflicts.

We should extend this behaviour and introduce similar automation to our particular needs.

Candidates (we will update this list as needed):

  • any package.json (scripts,dependencies) should be sorted to follow npm/yarn ordering when modified manually or by generator
  • ADD ANOTHER ONE

How should this work:

  • ideally during pre or push commit hook in the background
  • CI should fail on any kind of violations to not get out of sync if some power user will use --no-verify while running git commands

nit: This dependency should go on line 28 to maintain alphabetical order.

Originally posted by @khmakoto in #19517 (comment)

@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@Hotell Hotell reopened this Mar 2, 2022
@Hotell Hotell removed the Resolution: Soft Close Soft closing inactive issues over a certain period label Mar 2, 2022
@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Aug 29, 2022
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@microsoft-github-policy-service

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

7 similar comments
@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@Hotell Hotell reopened this Sep 19, 2023

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

This issue has not had activity for over 180 days! We're adding Soft close label and will close it soon for house-keeping purposes.
Still require assistance? Please add comment - "keep open".

@Hotell
Copy link
Contributor Author

Hotell commented Oct 7, 2024

keep open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Build System Resolution: Soft Close Soft closing inactive issues over a certain period
Projects
None yet
Development

No branches or pull requests

5 participants