babel-make-styles plugin causing build failures after migrating react-avatar to new DX

[Hotell]

After migrating react-avatar to new DX via yarn nx workspace-generator migrate-converged-pkg build started failing

#18866

---

The CI file is caused by babel-make-styles plugin:

Current:

After removing make styles plugin from babelrc:

↓↓↓↓

yarn lage build --to @fluentui/react-avatar

↓↓↓↓

can you help us out @layershifter ?

---

there is also another issue, that is caused by make-styles - it uses ES2015+ language features, thus API extractor will properly notify us that something is not ok. (this was reported/discovered by @ling1726 )

You'll need to change lib to es2015

Originally posted by @Hotell in #18866 (comment)

[Hotell]

quick fix provided by @layershifter

This looks like an issue with @linaria/shaker, I will debug the problem and report it. Currently, to unblock the PR I suggest to apply the following change:

  const rootClasses = styles.root;
  const svgClasses = styles.svg;

  return { containerProps, nativeProps, rootClasses, svgClasses };
};

+export const renderIcon = (
-const renderIcon = (
  SVGElement: (props: { svgClasses: string }) => JSX.Element,
): React.FC<React.HTMLAttributes<HTMLSpanElement>> => props => {
  const { containerProps, nativeProps, rootClasses, svgClasses } = useIconProps(props);

[ling1726]

I managed to get a minimal repro thanks to debugging guidance from @layershifter. It seems that this is an issue with linaria shaker.

Submitted issue: callstack/linaria#804 to them with the minimal repro

[Hotell]

@layershifter @ling1726 I see this issue was closed callstack/linaria#804, does it mean this one could be closed as well?

[layershifter]

@Hotell yes, this was fixed and can be closed.