Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

converged packages need ES2015: API extractor warns ES5 incompatible features in some packages #18682

Closed
ling1726 opened this issue Jun 23, 2021 · 3 comments
Closed

converged packages need ES2015: API extractor warns ES5 incompatible features in some packages #18682

ling1726 opened this issue Jun 23, 2021 · 3 comments
Labels
Area: Build System Fluent UI react-components (v9) Status: Fixed Fixed in some PR

Comments

@ling1726
Copy link
Member

ling1726 commented Jun 23, 2021 •
edited by Hotell
Loading

#18399 Modified the tsconfig of react-popover to use lib: [ES2015] because api extract would on proxy usages in make-styles:

image

This actually does make sense becuase proxy should not be supported in ES5. The warnings don't happen from TS build, and are only triggered on api extractor.

Similar issue that requires targeting ES2015 for api extractor:

The same issue does not happen in react-menu that was modified in the same PR with the same dependencies.
@ling1726 ling1726 mentioned this issue Jun 24, 2021
Merged
2 tasks
@ling1726 ling1726 changed the title API extractor warns ES5 incompatible features in react-popover but not react-menu API extractor warns ES5 incompatible features in some packages Jun 24, 2021
@Hotell Hotell mentioned this issue Jun 25, 2021
Merged
2 tasks
@Hotell Hotell changed the title API extractor warns ES5 incompatible features in some packages converged packages need ES2015: API extractor warns ES5 incompatible features in some packages Jun 28, 2021
@ecraig12345
Copy link
Member

It should be okay/desirable to change to ES2015 (or later) throughout our build once we confirm IE 11 support policy, right?

@ling1726
Copy link
Member Author

ling1726 commented Jul 2, 2021

Yeah, I will find some time during my shield rotation to make the IE11 support official (RFC)

@ecraig12345
Copy link
Member

Looks like the target thing was resolved separately under #19367, and the IE 11 RFC is done

@microsoft microsoft locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Area: Build System Fluent UI react-components (v9) Status: Fixed Fixed in some PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Hotell @ecraig12345 @ling1726