Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate react-components to use new storybook configuration (DX) #18514

Closed
Hotell opened this issue Jun 10, 2021 · 1 comment
Closed

migrate react-components to use new storybook configuration (DX) #18514

Hotell opened this issue Jun 10, 2021 · 1 comment
Assignees
@miroslavstastny
Labels
Effort II: Days Fluent UI react-components (v9) Priority 1: High Storybook
Milestone
August Project Cy...

Comments

@Hotell
Copy link
Contributor

Hotell commented Jun 10, 2021 •
edited
Loading

Describe the issue:

Actual behavior:

react-components is being build via just scripts and customised storybook machinery that lives within react-examples.

This disables any kind of functionality provided by colocated story setup:

  • common setup for parameters/decorators
  • generating controls from TS metadata (argTypes need to be specified by hand)
  • performance/speed to build

Expected behavior:

Prerequisites:

  • All vNext packages migrated to new DX (stage 1) that uses collocated stories and storybook configs
  • react-components
    • use same setup as collocated stories
    • are not handled by react-examples
    • collocated stories doesn't have to manually write argTypes (remove all of those from vNext collocated packages)
@Hotell Hotell mentioned this issue Jun 14, 2021
Merged
1 task
@Hotell Hotell mentioned this issue Jul 21, 2021
Merged
7 tasks
@Hotell Hotell added this to the August Project Cycle Q3 2021 milestone Aug 9, 2021
@PeterDraex PeterDraex mentioned this issue Aug 9, 2021
Merged
2 tasks
@behowell behowell assigned miroslavstastny and unassigned Hotell Aug 19, 2021
@Hotell
Copy link
Contributor Author

Hotell commented Aug 19, 2021

Implemented by #19040

@Hotell Hotell closed this as completed Aug 19, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@miroslavstastny miroslavstastny

Labels
Effort II: Days Fluent UI react-components (v9) Priority 1: High Storybook
Projects
None yet
Milestone
August Project Cycle Q3 2021
Development

No branches or pull requests
3 participants
@Hotell @miroslavstastny @behowell