-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node packages within repo are required to be built first before using (blocking no-build dev loop mode) #18357
Comments
discussed during vbuild sync and it looks like we are gonna go with babel-register approach -> #18144
|
`withFluentProvider` no build DX for storybook microsoft#18357. This PR reverts the register of that addon and only applying this addon to react-components breaks theming for all other packages
…ntProvider` (microsoft#20475) * revert(react-storybook-addon): Remove addon and reintroduce `withFluentProvider` no build DX for storybook microsoft#18357. This PR reverts the register of that addon and only applying this addon to react-components breaks theming for all other packages * Change files * update md
Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Problem details
#18337 introduced Jest aliases to workaround build issues, but the problem was not completely solved. As #16889 is going to use Jest aliases too, we will have the same problem there:
We met the problem before with
babel-make-styles
(#18040) and there is a proposal how to solve it (#18144).Possible solutions
@babel/register
/ts-node
/esbuild-register
/etc (WIP: buildless setup when consuming monorepo dependencies #18144)jest-serializer-make-styles
to JS, however it will not solve problem for other packages, POC in POC: rewrite jest-serializer-make-styles to JS #18356The text was updated successfully, but these errors were encountered: