Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node packages within repo are required to be built first before using (blocking no-build dev loop mode) #18357

Closed
layershifter opened this issue May 27, 2021 · 3 comments
Labels

Comments

@layershifter
Copy link
Member

layershifter commented May 27, 2021

Problem details

the issue exists for following packages:

  • jest-serializer-make-styles,
  • babel-make-styles,
  • make-styles,
  • make-styles-webpack-loader

#18337 introduced Jest aliases to workaround build issues, but the problem was not completely solved. As #16889 is going to use Jest aliases too, we will have the same problem there:

● Validation Error:

  Module @fluentui/jest-serializer-make-styles in the snapshotSerializers option was not found.
         <rootDir> is: office-ui-fabric-react\packages\react-image

  Configuration Documentation:
  https://jestjs.io/docs/configuration.html

We met the problem before with babel-make-styles (#18040) and there is a proposal how to solve it (#18144).

Possible solutions

@Hotell
Copy link
Contributor

Hotell commented Jun 16, 2021

discussed during vbuild sync and it looks like we are gonna go with babel-register approach -> #18144

@Hotell Hotell changed the title jest-serializer-make-styles: required to be built first node packages are required to be built first, before using those (jest-serializer-make-styles, babel-make-styles, make-styles, make-styles-webpack-laoder) Jul 15, 2021
@Hotell Hotell changed the title node packages are required to be built first, before using those (jest-serializer-make-styles, babel-make-styles, make-styles, make-styles-webpack-laoder) node packages within repo are required to be built first before using (blocking no-build dev loop mode) Jul 15, 2021
ling1726 added a commit to ling1726/fluentui that referenced this issue Nov 3, 2021
`withFluentProvider`

no build DX for storybook microsoft#18357. This PR reverts the register of that
addon and only applying this addon to react-components breaks theming
for all other packages
ling1726 added a commit that referenced this issue Nov 3, 2021
…ntProvider` (#20475)

* revert(react-storybook-addon): Remove addon and reintroduce
`withFluentProvider`

no build DX for storybook #18357. This PR reverts the register of that
addon and only applying this addon to react-components breaks theming
for all other packages

* Change files

* update md
mlp73 pushed a commit to mlp73/fluentui that referenced this issue Jan 17, 2022
…ntProvider` (microsoft#20475)

* revert(react-storybook-addon): Remove addon and reintroduce
`withFluentProvider`

no build DX for storybook microsoft#18357. This PR reverts the register of that
addon and only applying this addon to react-components breaks theming
for all other packages

* Change files

* update md
@microsoft-github-policy-service microsoft-github-policy-service bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Oct 11, 2023
@microsoft-github-policy-service

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants