Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu: Update aria relationships if user manually sets id prop #18318

Open
ling1726 opened this issue May 25, 2021 · 9 comments · May be fixed by #31339
Open

Menu: Update aria relationships if user manually sets id prop #18318

ling1726 opened this issue May 25, 2021 · 9 comments · May be fixed by #31339
Assignees
@ling1726
Labels
Component: Menu Fluent UI react-components (v9) Resolution: Soft Close Soft closing inactive issues over a certain period Status: In PR

Comments

@ling1726
Copy link
Member

ling1726 commented May 25, 2021 •
edited
Loading

Currently aria-labelledby or aria-describedby relationships in Menu are automatic. The useId hook is used to generate ids. If a users uses their own id prop they must also set their own aria relationship with that id manually.

Expected result: If the user manually sets id prop then aria relationships that depend on it should update. This should not work in the reverse (updating aria prop manually)

Reference PR comment about this: (aria-labelledby, #17387 (comment))
@ling1726 ling1726 self-assigned this May 25, 2021
@ling1726 ling1726 mentioned this issue May 25, 2021
Closed
25 tasks
@layershifter
Copy link
Member

@ling1726 is still a thing? Should we close it or add to v9 release?

@ling1726
Copy link
Member Author

@layershifter this is an enhancement. I don't think it matters, adding it should not be a breaking API change

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label May 28, 2022
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@layershifter layershifter reopened this May 29, 2022
@ling1726 ling1726 mentioned this issue Aug 1, 2022
Open
1 task
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Oct 26, 2022
@layershifter layershifter reopened this Oct 26, 2022
@layershifter layershifter removed the Resolution: Soft Close Soft closing inactive issues over a certain period label Jan 23, 2023
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Jun 22, 2023
@layershifter layershifter reopened this Jun 22, 2023
@layershifter layershifter removed the Resolution: Soft Close Soft closing inactive issues over a certain period label Jun 22, 2023
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

1 similar comment
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution: Soft Close Soft closing inactive issues over a certain period labels Nov 19, 2023
@ling1726 ling1726 reopened this Nov 20, 2023
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@layershifter layershifter reopened this Apr 18, 2024
@layershifter layershifter removed the Resolution: Soft Close Soft closing inactive issues over a certain period label Apr 18, 2024
@jacksonv1lle jacksonv1lle linked a pull request May 11, 2024 that will close this issue
Open
@microsoft-github-policy-service microsoft-github-policy-service bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Nov 8, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

This issue has not had activity for over 180 days! We're adding Soft close label and will close it soon for house-keeping purposes.
Still require assistance? Please add comment - "keep open".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ling1726 ling1726

Labels
Component: Menu Fluent UI react-components (v9) Resolution: Soft Close Soft closing inactive issues over a certain period Status: In PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure specified trigger id is used for menu aria-labelledby jacksonv1lle/fluentui
3 participants
@layershifter @ling1726 @msft-fluent-ui-bot