Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove @nrwl/workspace from satisfied ignore regexp #18036

Closed
Hotell opened this issue May 4, 2021 · 11 comments · Fixed by #18041
Closed

build: remove @nrwl/workspace from satisfied ignore regexp #18036

Hotell opened this issue May 4, 2021 · 11 comments · Fixed by #18041
Assignees
@TristanWatanabe
Labels
Good First Issue 🏆 Help Wanted ✨ Status: Fixed Fixed in some PR

Comments

@Hotell
Copy link
Contributor

Hotell commented May 4, 2021

Problem description:

  • @nrwl/workspace requires prettier 2.x as peer Dep, we are on v1
  • after upgrading remove @nrwl from root package.json

Action needed

// @filename /package.json
-"satisfied": "satisfied --skip-invalid --ignore \"sass|@testing-library|@nrwl/workspace\"",
+"satisfied": "satisfied --skip-invalid --ignore \"sass|@testing-library\"",
@ecraig12345 ecraig12345 mentioned this issue May 4, 2021
Merged
2 tasks
@msft-fluent-ui-bot msft-fluent-ui-bot added Status: Fixed Fixed in some PR and removed Status: In PR labels May 20, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #18041, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #18041, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #18041, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #18041, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #18041, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #18041, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #18041, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #18041, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #18041, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #18041, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #18041, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@microsoft microsoft locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TristanWatanabe TristanWatanabe

Labels
Good First Issue 🏆 Help Wanted ✨ Status: Fixed Fixed in some PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update prettier to latest version and format all files ecraig12345/office-ui-fabric-react
4 participants
@Hotell @ecraig12345 @TristanWatanabe @msft-fluent-ui-bot