Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Convergence #16658

Closed
25 of 32 tasks
kubkon opened this issue Jan 27, 2021 · 9 comments
Closed
25 of 32 tasks

Image Convergence #16658

kubkon opened this issue Jan 27, 2021 · 9 comments
Assignees
@tringakrasniqi
Labels
Area: Components Component: Image Fluent UI react-components (v9) Phase: 4 Convergence Iterations phase 4 Resolution: Soft Close Soft closing inactive issues over a certain period Type: Epic
Milestone
October Project C...

Comments

@kubkon
Copy link
Contributor

kubkon commented Jan 27, 2021 •
edited by tringakrasniqi
Loading

Preparation:

Implementation

packages/react-image

Validation

  • Started validating
  • Add and validate in UI Builder
  • Add and validate in docs site
  • Validate with token pipeline
  • Validate in product
  • Finalize migration guide
    • Author codemods
@kubkon kubkon self-assigned this Jan 27, 2021
@kubkon kubkon added this to the February Project Cycle 2021 milestone Feb 2, 2021
@kubkon
Copy link
Contributor Author

kubkon commented Feb 3, 2021 •
edited
Loading

Goals for February:

  • OpenUI research drafted
  • Spec draft (v0 vs v7)
  • revamp current impl to use makeStyles and React hooks
  • add basic storybook stories

For that one, I'm super tempted to forego scaffolding in favour of initially starting off with something clean, in a separate repo/dir with clean (minimal) build structure.

@kubkon kubkon mentioned this issue Feb 9, 2021
Merged
2 tasks
@kubkon
Copy link
Contributor Author

kubkon commented Feb 9, 2021 •
edited
Loading

Update 09-02-2021

Making some good progress on aligning the existing react-image with the convergence RFC #16806 and makeStyles for styling #16631. The changes are still in draft but feel free to drop comments now: #16894.

@kubkon
Copy link
Contributor Author

kubkon commented Feb 16, 2021

Update 16-02-2021

react-image is now up to date with the convergence direction and the changes are ready for merging here #16894.

@kubkon
Copy link
Contributor Author

kubkon commented Feb 23, 2021 •
edited
Loading

Update 23-02-2021

I've started doing OpenUI research for Image/img, and gathering intel what's out there in the wild. I hope for the first draft PR into the OpenUI repo to be ready by tomorrow.

@kubkon
Copy link
Contributor Author

kubkon commented Mar 1, 2021

Goals for March:

@JustSlone
Copy link
Collaborator

Update:

  • getting started on Spec draft (v0 vs v7)

@JustSlone
Copy link
Collaborator

Update:

Working on:

  • Spec draft for v0 vs v8 (based on @andrefcdias work on flex)

@kubkon kubkon mentioned this issue Mar 29, 2021
Closed
2 tasks
@gouttierre gouttierre added the Phase: 1 Convergence Iterations phase 1 label Apr 13, 2021
@tringakrasniqi tringakrasniqi self-assigned this Jul 12, 2021
@tringakrasniqi tringakrasniqi added Phase: 4 Convergence Iterations phase 4 and removed Phase: 1 Convergence Iterations phase 1 labels Oct 5, 2021
@Hotell Hotell removed their assignment Oct 20, 2021
@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Apr 19, 2022
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@khmakoto khmakoto reopened this Apr 19, 2022
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@microsoft microsoft locked as resolved and limited conversation to collaborators Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tringakrasniqi tringakrasniqi

Labels
Area: Components Component: Image Fluent UI react-components (v9) Phase: 4 Convergence Iterations phase 4 Resolution: Soft Close Soft closing inactive issues over a certain period Type: Epic
Projects
None yet
Milestone
October Project Cycle Q4 2021
Development

No branches or pull requests
8 participants
@Hotell @kubkon @khmakoto @tringakrasniqi @paulgildea @JustSlone @msft-fluent-ui-bot @gouttierre