From e0565090ebc05252c010eeb1251bcceaab48f06b Mon Sep 17 00:00:00 2001 From: Martin Hochel Date: Thu, 6 Apr 2023 16:54:41 +0200 Subject: [PATCH] fixup! feat(scripts-generators): incorporate base all generation to create-package and validate integrity on CI --- scripts/generators/generate-ts-base-all-json.ts | 1 + scripts/storybook/src/utils.js | 8 +++++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/scripts/generators/generate-ts-base-all-json.ts b/scripts/generators/generate-ts-base-all-json.ts index 106c833b77f3f2..f4889b9b6b7830 100644 --- a/scripts/generators/generate-ts-base-all-json.ts +++ b/scripts/generators/generate-ts-base-all-json.ts @@ -20,6 +20,7 @@ export function main(options?: yargs.Arguments<{ verify?: boolean }>) { const { mergedTsConfig, existingTsConfig, tsConfigAllFileName } = createPathAliasesConfig({ relativeFolderPathFromRoot: '.', + writeFileToDisk: verify === false, }); if (verify && !isEqual(existingTsConfig, mergedTsConfig)) { diff --git a/scripts/storybook/src/utils.js b/scripts/storybook/src/utils.js index 357d10270fb09c..f662abb60c046a 100644 --- a/scripts/storybook/src/utils.js +++ b/scripts/storybook/src/utils.js @@ -359,10 +359,10 @@ function overrideDefaultBabelLoader(options) { * * Main purpose of this is to be used for build-less DX in webpack in tandem with {@link registerTsPaths} * - * @param {{relativeFolderPathFromRoot?:string}} options + * @param {{relativeFolderPathFromRoot?:string,writeFileToDisk?:boolean}} options */ function createPathAliasesConfig(options = {}) { - const { relativeFolderPathFromRoot = './dist' } = options; + const { relativeFolderPathFromRoot = './dist', writeFileToDisk = true } = options; const rootPath = workspaceRoot; const mergedTsConfigRoot = path.join(rootPath, relativeFolderPathFromRoot); const tsConfigAllFileName = 'tsconfig.base.all.json'; @@ -395,7 +395,9 @@ function createPathAliasesConfig(options = {}) { }, }; - writeJsonFile(tsConfigAllPath, mergedTsConfig); + if (writeFileToDisk) { + writeJsonFile(tsConfigAllPath, mergedTsConfig); + } return { tsConfigAllPath, tsConfigAllFileName, mergedTsConfig, existingTsConfig }; }