From d1228a137bb5f28014bad869d88584ae95ba46da Mon Sep 17 00:00:00 2001 From: Bernardo Sunderhus Date: Thu, 10 Nov 2022 14:22:28 +0100 Subject: [PATCH] chore(react-dialog): removes unnecessary union case for DialogOpenChangeData (#25504) --- ...react-dialog-64415a56-f53d-498c-8000-38ce9610b103.json | 7 +++++++ .../react-components/react-dialog/etc/react-dialog.api.md | 4 ---- .../react-dialog/src/components/Dialog/Dialog.types.ts | 8 -------- 3 files changed, 7 insertions(+), 12 deletions(-) create mode 100644 change/@fluentui-react-dialog-64415a56-f53d-498c-8000-38ce9610b103.json diff --git a/change/@fluentui-react-dialog-64415a56-f53d-498c-8000-38ce9610b103.json b/change/@fluentui-react-dialog-64415a56-f53d-498c-8000-38ce9610b103.json new file mode 100644 index 0000000000000..3b38921299031 --- /dev/null +++ b/change/@fluentui-react-dialog-64415a56-f53d-498c-8000-38ce9610b103.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "chore: removes unnecessary union case for DialogOpenChangeData", + "packageName": "@fluentui/react-dialog", + "email": "bernardo.sunderhus@gmail.com", + "dependentChangeType": "patch" +} diff --git a/packages/react-components/react-dialog/etc/react-dialog.api.md b/packages/react-components/react-dialog/etc/react-dialog.api.md index f8055ff2e3360..f2cfd7212ae85 100644 --- a/packages/react-components/react-dialog/etc/react-dialog.api.md +++ b/packages/react-components/react-dialog/etc/react-dialog.api.md @@ -81,10 +81,6 @@ export type DialogContentState = ComponentState; // @public (undocumented) export type DialogOpenChangeData = { - type: 'dialogCancel'; - open: boolean; - event: React_2.SyntheticEvent; -} | { type: 'escapeKeyDown'; open: boolean; event: React_2.KeyboardEvent; diff --git a/packages/react-components/react-dialog/src/components/Dialog/Dialog.types.ts b/packages/react-components/react-dialog/src/components/Dialog/Dialog.types.ts index f24c7c59eaa6c..ee5f07b57137a 100644 --- a/packages/react-components/react-dialog/src/components/Dialog/Dialog.types.ts +++ b/packages/react-components/react-dialog/src/components/Dialog/Dialog.types.ts @@ -8,14 +8,6 @@ export type DialogSlots = {}; export type DialogOpenChangeEvent = DialogOpenChangeData['event']; export type DialogOpenChangeData = - | { - /** - * triggered when Escape key is pressed in a native `dialog` - */ - type: 'dialogCancel'; - open: boolean; - event: React.SyntheticEvent; - } | { type: 'escapeKeyDown'; open: boolean;