From 8a09087b4215a36a50b6d3478cd2b74155c9c630 Mon Sep 17 00:00:00 2001 From: jspurlin Date: Thu, 5 Aug 2021 20:18:18 -0500 Subject: [PATCH] make-styles: fix types.ts compatibility with typescript < v4 (#19281) Make-styles: Types.ts was updated in a way that's not compatible with typescript < v4 (named tuples) --- ...i-make-styles-221c14b4-6ba3-4256-833e-ababcabba480.json | 7 +++++++ packages/make-styles/etc/make-styles.api.md | 5 ++--- packages/make-styles/src/types.ts | 4 ++-- 3 files changed, 11 insertions(+), 5 deletions(-) create mode 100644 change/@fluentui-make-styles-221c14b4-6ba3-4256-833e-ababcabba480.json diff --git a/change/@fluentui-make-styles-221c14b4-6ba3-4256-833e-ababcabba480.json b/change/@fluentui-make-styles-221c14b4-6ba3-4256-833e-ababcabba480.json new file mode 100644 index 00000000000000..384db330f99c3e --- /dev/null +++ b/change/@fluentui-make-styles-221c14b4-6ba3-4256-833e-ababcabba480.json @@ -0,0 +1,7 @@ +{ + "type": "prerelease", + "comment": "Make-styles: Types.ts was updated in a way that's not compatible with typescript < v4 (named tuples)", + "packageName": "@fluentui/make-styles", + "email": "jspurlin@microsoft.com", + "dependentChangeType": "patch" +} diff --git a/packages/make-styles/etc/make-styles.api.md b/packages/make-styles/etc/make-styles.api.md index 995c48ce222a58..9cbb065a112599 100644 --- a/packages/make-styles/etc/make-styles.api.md +++ b/packages/make-styles/etc/make-styles.api.md @@ -18,7 +18,7 @@ export function createCSSVariablesProxy(prefix?: string): unknown; export function createDOMRenderer(target?: Document | undefined): MakeStylesRenderer; // @public (undocumented) -export type CSSClasses = /* ltrClassName */ string | [ltrClassName: string, rtlClassName: string]; +export type CSSClasses = /* ltrClassName */ string | [/* ltrClassName */ string, /* rtlClassName */ string]; // @public (undocumented) export type CSSClassesMap = Record; @@ -50,7 +50,7 @@ export const LOOKUP_DEFINITIONS_INDEX = 0; export const LOOKUP_DIR_INDEX = 1; // @public (undocumented) -export type LookupItem = [definitions: CSSClassesMap, dir: 'rtl' | 'ltr']; +export type LookupItem = [/* definitions */ CSSClassesMap, /* dir */ /* dir */ 'rtl' | 'ltr']; // @public (undocumented) export type MakeStaticStyles = ({ @@ -159,7 +159,6 @@ export const styleBucketOrdering: StyleBucketName[]; // @public (undocumented) export type StylesBySlots = Record>; - // (No @packageDocumentation comment for this package) ``` diff --git a/packages/make-styles/src/types.ts b/packages/make-styles/src/types.ts index 0f9d9d79228aae..1d038d42c3ba25 100644 --- a/packages/make-styles/src/types.ts +++ b/packages/make-styles/src/types.ts @@ -88,7 +88,7 @@ export type StyleBucketName = export type SequenceHash = string; export type PropertyHash = string; -export type CSSClasses = /* ltrClassName */ string | [ltrClassName: string, rtlClassName: string]; +export type CSSClasses = /* ltrClassName */ string | [/* ltrClassName */ string, /* rtlClassName */ string]; export type CSSClassesMap = Record; export type CSSClassesMapBySlot = Record; @@ -97,4 +97,4 @@ export type CSSRulesByBucket = Partial>; export type StylesBySlots = Record>; -export type LookupItem = [definitions: CSSClassesMap, dir: 'rtl' | 'ltr']; +export type LookupItem = [/* definitions */ CSSClassesMap, /* dir */ 'rtl' | 'ltr'];