Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in thickness of strokes for filled icons #256

Open
TaigaYamada opened this issue May 20, 2021 · 0 comments
Open

Inconsistency in thickness of strokes for filled icons #256

TaigaYamada opened this issue May 20, 2021 · 0 comments

Comments

@TaigaYamada
Copy link

In the Figma guideline Details 1 point 1, it says:

Icons that can't close should have a thicker stroke by .5 px.

The third point of the same section says:

The stroke shouldn't change when filling in shapes.

Combined, these 2 rules indicate that when an icon contains parts that can be filled and other parts that can't be, the parts that can't be filled should be thickened. The prohibition of mixed techniques only applies to parts that are filled in, as quoted above and as provided in the picture inside of the guideline.

However, the naming of the guideline Details 1 point 3 as "Mixing techniques" is slightly misleading and may lead one to think that when any part is filled in, the rest of the icon should not be thickened.

This potentially ambiguous guideline has affected many, many icons.

Examples of affected, un-thickened icons

  • Align Bottom (Filled)

    • image
    • Line at the bottom should be thickened
  • Animal Dog (Filled)

    • image
    • Tail should be thickened

Examples of (I believe correctly) thickened icons

  • Airplane Take Off (Filled)

    • image
    • Ground plane is correctly thickened
  • Camera Switch (Filled)

    • image
    • Arrows are correctly thickened

I usually try to spot all instances of the problem before filing an issue, but this time, a far greater number of icons are affected by the issue than anything I have filed so far. The 4 icons mentioned above are just the tip of the iceberg.

Either way this is settled (unifying the style in thickened or un-thickened), many icons would have to be revised.

However, considering the current guideline, I believe the correct choice is to unify the style in thickened strokes.
This way, consistency within the icon style is preserved too. It would look weird if one filled icon had a different stroke thickness from another filled icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant