From e3472d4f8698c39ff61f9eb895fa6e194b32f51e Mon Sep 17 00:00:00 2001 From: Ayush Singh Date: Fri, 31 Mar 2023 01:34:47 +0530 Subject: [PATCH 01/13] Add accessibility role to text --- packages/components/text/src/Text.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/components/text/src/Text.tsx b/packages/components/text/src/Text.tsx index 0ddbb9e62c..ebe4139dcf 100644 --- a/packages/components/text/src/Text.tsx +++ b/packages/components/text/src/Text.tsx @@ -138,7 +138,8 @@ export const Text = compressible((props: TextProps, useTo // return a continuation function that allows this text to be compressed return (extra: TextProps, children: React.ReactNode) => { - const mergedProps = { + const mergedProps: TextProps = { + accessibilityRole: 'text', ...rest, ...keyProps, ...filteredProps, From 2a88840bf217df06eddf008900bbf8c7262a1f93 Mon Sep 17 00:00:00 2001 From: Ayush Singh Date: Fri, 31 Mar 2023 01:53:47 +0530 Subject: [PATCH 02/13] Fix text overflowing off the screen --- packages/components/text/src/Text.tsx | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/components/text/src/Text.tsx b/packages/components/text/src/Text.tsx index ebe4139dcf..a0c7de0c9e 100644 --- a/packages/components/text/src/Text.tsx +++ b/packages/components/text/src/Text.tsx @@ -1,6 +1,6 @@ /** @jsx withSlots */ import React from 'react'; -import { I18nManager, Platform, Text as RNText } from 'react-native'; +import { I18nManager, Platform, Text as RNText, View } from 'react-native'; import { useFontMetricsScaleFactors } from '@fluentui-react-native/experimental-native-font-metrics'; import type { UseTokens, FontWeightValue } from '@fluentui-react-native/framework'; @@ -155,9 +155,11 @@ export const Text = compressible((props: TextProps, useTo delete (mergedProps.style as TextTokens).maximumFontSize; return ( - - {children} - + + + {children} + + ); }; }, useTextTokens); From 8957463d44be3c73111f17f14f40e7fe8bb069a1 Mon Sep 17 00:00:00 2001 From: Ayush Singh Date: Fri, 31 Mar 2023 02:29:56 +0530 Subject: [PATCH 03/13] Update snaps --- .../__snapshots__/Text.test.tsx.snap | 150 +++++++++++------- 1 file changed, 93 insertions(+), 57 deletions(-) diff --git a/packages/components/text/src/__tests__/__snapshots__/Text.test.tsx.snap b/packages/components/text/src/__tests__/__snapshots__/Text.test.tsx.snap index 180f685128..204cff4917 100644 --- a/packages/components/text/src/__tests__/__snapshots__/Text.test.tsx.snap +++ b/packages/components/text/src/__tests__/__snapshots__/Text.test.tsx.snap @@ -1,90 +1,126 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`Text component tests Text all props 1`] = ` - - All props - + + All props + + `; exports[`Text component tests Text all tokens 1`] = ` - - All tokens - + + All tokens + + `; exports[`Text component tests Text default 1`] = ` - - Text default - + + Text default + + `; exports[`Text component tests Text variants render correctly with style 1`] = ` - - Header Text - + + Header Text + + `; From 2f7a792bd2fcd1842fb4c859b40e8b91bda93f7a Mon Sep 17 00:00:00 2001 From: Ayush Singh Date: Fri, 31 Mar 2023 02:32:30 +0530 Subject: [PATCH 04/13] Change files --- ...t-native-text-b1ea1d13-9ce7-4949-902a-b4894ce95b80.json | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 change/@fluentui-react-native-text-b1ea1d13-9ce7-4949-902a-b4894ce95b80.json diff --git a/change/@fluentui-react-native-text-b1ea1d13-9ce7-4949-902a-b4894ce95b80.json b/change/@fluentui-react-native-text-b1ea1d13-9ce7-4949-902a-b4894ce95b80.json new file mode 100644 index 0000000000..17e97cf187 --- /dev/null +++ b/change/@fluentui-react-native-text-b1ea1d13-9ce7-4949-902a-b4894ce95b80.json @@ -0,0 +1,7 @@ +{ + "type": "minor", + "comment": "Fix text overflowing off the screen", + "packageName": "@fluentui-react-native/text", + "email": "ayushsinghs@yahoo.in", + "dependentChangeType": "patch" +} From a5753653d6684d7e6a2a3e2f9cd0dbcec320b073 Mon Sep 17 00:00:00 2001 From: Ayush Singh Date: Mon, 3 Apr 2023 11:23:22 +0530 Subject: [PATCH 05/13] Fix text not wrapping --- packages/components/text/src/Text.tsx | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/components/text/src/Text.tsx b/packages/components/text/src/Text.tsx index a0c7de0c9e..e7e6b952b2 100644 --- a/packages/components/text/src/Text.tsx +++ b/packages/components/text/src/Text.tsx @@ -147,7 +147,7 @@ export const Text = compressible((props: TextProps, useTo ...(dynamicTypeVariant !== undefined && { allowFontScaling: false }), // GH #2268: Remove once RN Core properly supports Dynamic Type scaling onPress, numberOfLines: truncate || !wrap ? 1 : 0, - style: mergeStyles(tokenStyle, props.style, extra?.style, scaleStyleAdjustments), + style: mergeStyles({ flexShrink: 1 }, tokenStyle, props.style, extra?.style, scaleStyleAdjustments), }; // GH #2268: RN Text doesn't recognize these properties yet, so don't let them leak through or RN will complain about invalid props @@ -155,11 +155,9 @@ export const Text = compressible((props: TextProps, useTo delete (mergedProps.style as TextTokens).maximumFontSize; return ( - - - {children} - - + + {children} + ); }; }, useTextTokens); From aaba9ce5d0eb73b5645203d0010c3cca5dbaddbf Mon Sep 17 00:00:00 2001 From: Ayush Singh Date: Mon, 3 Apr 2023 11:56:20 +0530 Subject: [PATCH 06/13] Fix tests and update snaps --- .../__snapshots__/Badge.test.tsx.snap | 14 ++ .../src/FAB/__snapshots__/FAB.test.tsx.snap | 4 + .../__snapshots__/ToggleButton.test.tsx.snap | 2 + .../src/__snapshots__/Button.test.tsx.snap | 18 +++ .../__snapshots__/Link.test.tsx.snap | 7 + .../__snapshots__/Menu.test.tsx.snap | 16 ++ .../__snapshots__/Notification.test.tsx.snap | 4 + packages/components/text/src/Text.tsx | 5 +- .../__snapshots__/Text.test.tsx.snap | 150 +++++++----------- .../__snapshots__/Divider.test.tsx.snap | 2 + .../__snapshots__/MenuButton.test.tsx.snap | 2 + .../RadioExperimental.test.tsx.snap | 4 + .../RadioGroupExperimental.test.tsx.snap | 38 +++++ .../__snapshots__/Tabs.test.tsx.snap | 14 ++ 14 files changed, 189 insertions(+), 91 deletions(-) diff --git a/packages/components/Badge/src/__tests__/__snapshots__/Badge.test.tsx.snap b/packages/components/Badge/src/__tests__/__snapshots__/Badge.test.tsx.snap index 00df6ad22d..7bacd0ed1b 100644 --- a/packages/components/Badge/src/__tests__/__snapshots__/Badge.test.tsx.snap +++ b/packages/components/Badge/src/__tests__/__snapshots__/Badge.test.tsx.snap @@ -39,6 +39,7 @@ exports[`Badge component tests Badge all props 1`] = ` ♣ ((props: TextProps, useTo // now build the text style from tokens that can be shared between different Text instances const [tokenStyle] = cache( () => ({ + flexShrink: 1, // Fixes bug in RN where text does not wrap correctly. RN bug #1438 margin: 0, color: tokens.color, fontStyle: tokens.fontStyle, @@ -147,7 +148,7 @@ export const Text = compressible((props: TextProps, useTo ...(dynamicTypeVariant !== undefined && { allowFontScaling: false }), // GH #2268: Remove once RN Core properly supports Dynamic Type scaling onPress, numberOfLines: truncate || !wrap ? 1 : 0, - style: mergeStyles({ flexShrink: 1 }, tokenStyle, props.style, extra?.style, scaleStyleAdjustments), + style: mergeStyles(tokenStyle, props.style, extra?.style, scaleStyleAdjustments), }; // GH #2268: RN Text doesn't recognize these properties yet, so don't let them leak through or RN will complain about invalid props diff --git a/packages/components/text/src/__tests__/__snapshots__/Text.test.tsx.snap b/packages/components/text/src/__tests__/__snapshots__/Text.test.tsx.snap index 204cff4917..27cbf809ff 100644 --- a/packages/components/text/src/__tests__/__snapshots__/Text.test.tsx.snap +++ b/packages/components/text/src/__tests__/__snapshots__/Text.test.tsx.snap @@ -1,126 +1,98 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`Text component tests Text all props 1`] = ` - - - All props - - + All props + `; exports[`Text component tests Text all tokens 1`] = ` - - - All tokens - - + All tokens + `; exports[`Text component tests Text default 1`] = ` - - - Text default - - + Text default + `; exports[`Text component tests Text variants render correctly with style 1`] = ` - - - Header Text - - + Header Text + `; diff --git a/packages/experimental/Divider/src/__tests__/__snapshots__/Divider.test.tsx.snap b/packages/experimental/Divider/src/__tests__/__snapshots__/Divider.test.tsx.snap index a1b8821b96..9dffd8e7e8 100644 --- a/packages/experimental/Divider/src/__tests__/__snapshots__/Divider.test.tsx.snap +++ b/packages/experimental/Divider/src/__tests__/__snapshots__/Divider.test.tsx.snap @@ -184,12 +184,14 @@ exports[`Divider component tests Divider with text 1`] = ` } > Date: Mon, 3 Apr 2023 12:05:40 +0530 Subject: [PATCH 07/13] Remove default accessibility role text --- packages/components/text/src/Text.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/components/text/src/Text.tsx b/packages/components/text/src/Text.tsx index 01be761a75..9ff420b428 100644 --- a/packages/components/text/src/Text.tsx +++ b/packages/components/text/src/Text.tsx @@ -140,7 +140,6 @@ export const Text = compressible((props: TextProps, useTo // return a continuation function that allows this text to be compressed return (extra: TextProps, children: React.ReactNode) => { const mergedProps: TextProps = { - accessibilityRole: 'text', ...rest, ...keyProps, ...filteredProps, From 59f2bd5e832bcceee5814209b54dbf85fac9b01c Mon Sep 17 00:00:00 2001 From: Ayush Singh Date: Mon, 3 Apr 2023 14:04:43 +0530 Subject: [PATCH 08/13] Revert "Remove default accessibility role text" This reverts commit 20130c25db52fa9522e8b2541e3486fdc5ba59fc. --- packages/components/text/src/Text.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/components/text/src/Text.tsx b/packages/components/text/src/Text.tsx index 9ff420b428..01be761a75 100644 --- a/packages/components/text/src/Text.tsx +++ b/packages/components/text/src/Text.tsx @@ -140,6 +140,7 @@ export const Text = compressible((props: TextProps, useTo // return a continuation function that allows this text to be compressed return (extra: TextProps, children: React.ReactNode) => { const mergedProps: TextProps = { + accessibilityRole: 'text', ...rest, ...keyProps, ...filteredProps, From 4f5fadacc34f4bcd2067da5d0ffb4af2601f801b Mon Sep 17 00:00:00 2001 From: Ayush Singh Date: Mon, 3 Apr 2023 14:17:08 +0530 Subject: [PATCH 09/13] Update snaps --- .../src/__tests__/__snapshots__/Badge.test.tsx.snap | 2 ++ .../Button/src/FAB/__snapshots__/FAB.test.tsx.snap | 2 ++ .../__snapshots__/ToggleButton.test.tsx.snap | 1 + .../Button/src/__snapshots__/Button.test.tsx.snap | 9 +++++++++ .../src/__tests__/__snapshots__/Divider.test.tsx.snap | 2 ++ .../src/__tests__/__snapshots__/Menu.test.tsx.snap | 8 ++++++++ .../__tests__/__snapshots__/Notification.test.tsx.snap | 1 + .../__tests__/__snapshots__/MenuButton.test.tsx.snap | 1 + .../__snapshots__/RadioExperimental.test.tsx.snap | 1 + .../__snapshots__/RadioGroupExperimental.test.tsx.snap | 10 ++++++++++ 10 files changed, 37 insertions(+) diff --git a/packages/components/Badge/src/__tests__/__snapshots__/Badge.test.tsx.snap b/packages/components/Badge/src/__tests__/__snapshots__/Badge.test.tsx.snap index f4950bc4b4..193582e64c 100644 --- a/packages/components/Badge/src/__tests__/__snapshots__/Badge.test.tsx.snap +++ b/packages/components/Badge/src/__tests__/__snapshots__/Badge.test.tsx.snap @@ -180,6 +180,7 @@ exports[`Badge component tests Filled badge with shadow 1`] = ` } > Date: Mon, 3 Apr 2023 14:22:38 +0530 Subject: [PATCH 10/13] Change files --- ...-native-badge-feb689b1-06fe-435b-a373-2f1bbd599581.json | 7 +++++++ ...native-button-e18cbcea-165b-4b0b-b025-0e00edc776e8.json | 7 +++++++ ...ative-divider-557c1c15-03b1-4007-bc1d-04552901a513.json | 7 +++++++ ...l-menu-button-136589b3-4a23-4570-bf5a-28a2540f52fd.json | 7 +++++++ ...l-radio-group-64061eb3-b4b2-48b4-a93d-bd1619719e66.json | 7 +++++++ ...rimental-tabs-e9d30d85-d5d3-4d9d-b2b4-13be03e53eeb.json | 7 +++++++ ...t-native-link-b9049396-6b19-4751-9370-0b65d7d4f36c.json | 7 +++++++ ...t-native-menu-4429ef8f-e6e0-4fda-898e-d1cac73b4e64.json | 7 +++++++ ...-notification-ad05670d-b703-43ab-808a-e9f140d89be1.json | 7 +++++++ 9 files changed, 63 insertions(+) create mode 100644 change/@fluentui-react-native-badge-feb689b1-06fe-435b-a373-2f1bbd599581.json create mode 100644 change/@fluentui-react-native-button-e18cbcea-165b-4b0b-b025-0e00edc776e8.json create mode 100644 change/@fluentui-react-native-divider-557c1c15-03b1-4007-bc1d-04552901a513.json create mode 100644 change/@fluentui-react-native-experimental-menu-button-136589b3-4a23-4570-bf5a-28a2540f52fd.json create mode 100644 change/@fluentui-react-native-experimental-radio-group-64061eb3-b4b2-48b4-a93d-bd1619719e66.json create mode 100644 change/@fluentui-react-native-experimental-tabs-e9d30d85-d5d3-4d9d-b2b4-13be03e53eeb.json create mode 100644 change/@fluentui-react-native-link-b9049396-6b19-4751-9370-0b65d7d4f36c.json create mode 100644 change/@fluentui-react-native-menu-4429ef8f-e6e0-4fda-898e-d1cac73b4e64.json create mode 100644 change/@fluentui-react-native-notification-ad05670d-b703-43ab-808a-e9f140d89be1.json diff --git a/change/@fluentui-react-native-badge-feb689b1-06fe-435b-a373-2f1bbd599581.json b/change/@fluentui-react-native-badge-feb689b1-06fe-435b-a373-2f1bbd599581.json new file mode 100644 index 0000000000..54e6091b59 --- /dev/null +++ b/change/@fluentui-react-native-badge-feb689b1-06fe-435b-a373-2f1bbd599581.json @@ -0,0 +1,7 @@ +{ + "type": "none", + "comment": "Fix text not wrapping", + "packageName": "@fluentui-react-native/badge", + "email": "ayushsinghs@yahoo.in", + "dependentChangeType": "none" +} diff --git a/change/@fluentui-react-native-button-e18cbcea-165b-4b0b-b025-0e00edc776e8.json b/change/@fluentui-react-native-button-e18cbcea-165b-4b0b-b025-0e00edc776e8.json new file mode 100644 index 0000000000..2d8953990d --- /dev/null +++ b/change/@fluentui-react-native-button-e18cbcea-165b-4b0b-b025-0e00edc776e8.json @@ -0,0 +1,7 @@ +{ + "type": "none", + "comment": "Fix text not wrapping", + "packageName": "@fluentui-react-native/button", + "email": "ayushsinghs@yahoo.in", + "dependentChangeType": "none" +} diff --git a/change/@fluentui-react-native-divider-557c1c15-03b1-4007-bc1d-04552901a513.json b/change/@fluentui-react-native-divider-557c1c15-03b1-4007-bc1d-04552901a513.json new file mode 100644 index 0000000000..b65e409d6e --- /dev/null +++ b/change/@fluentui-react-native-divider-557c1c15-03b1-4007-bc1d-04552901a513.json @@ -0,0 +1,7 @@ +{ + "type": "none", + "comment": "Fix text not wrapping", + "packageName": "@fluentui-react-native/divider", + "email": "ayushsinghs@yahoo.in", + "dependentChangeType": "none" +} diff --git a/change/@fluentui-react-native-experimental-menu-button-136589b3-4a23-4570-bf5a-28a2540f52fd.json b/change/@fluentui-react-native-experimental-menu-button-136589b3-4a23-4570-bf5a-28a2540f52fd.json new file mode 100644 index 0000000000..e917d1a826 --- /dev/null +++ b/change/@fluentui-react-native-experimental-menu-button-136589b3-4a23-4570-bf5a-28a2540f52fd.json @@ -0,0 +1,7 @@ +{ + "type": "none", + "comment": "Fix text not wrapping", + "packageName": "@fluentui-react-native/experimental-menu-button", + "email": "ayushsinghs@yahoo.in", + "dependentChangeType": "none" +} diff --git a/change/@fluentui-react-native-experimental-radio-group-64061eb3-b4b2-48b4-a93d-bd1619719e66.json b/change/@fluentui-react-native-experimental-radio-group-64061eb3-b4b2-48b4-a93d-bd1619719e66.json new file mode 100644 index 0000000000..eb9d2895ed --- /dev/null +++ b/change/@fluentui-react-native-experimental-radio-group-64061eb3-b4b2-48b4-a93d-bd1619719e66.json @@ -0,0 +1,7 @@ +{ + "type": "none", + "comment": "Fix text not wrapping", + "packageName": "@fluentui-react-native/experimental-radio-group", + "email": "ayushsinghs@yahoo.in", + "dependentChangeType": "none" +} diff --git a/change/@fluentui-react-native-experimental-tabs-e9d30d85-d5d3-4d9d-b2b4-13be03e53eeb.json b/change/@fluentui-react-native-experimental-tabs-e9d30d85-d5d3-4d9d-b2b4-13be03e53eeb.json new file mode 100644 index 0000000000..aac5d07bef --- /dev/null +++ b/change/@fluentui-react-native-experimental-tabs-e9d30d85-d5d3-4d9d-b2b4-13be03e53eeb.json @@ -0,0 +1,7 @@ +{ + "type": "none", + "comment": "Fix text not wrapping", + "packageName": "@fluentui-react-native/experimental-tabs", + "email": "ayushsinghs@yahoo.in", + "dependentChangeType": "none" +} diff --git a/change/@fluentui-react-native-link-b9049396-6b19-4751-9370-0b65d7d4f36c.json b/change/@fluentui-react-native-link-b9049396-6b19-4751-9370-0b65d7d4f36c.json new file mode 100644 index 0000000000..d9f56a9fd9 --- /dev/null +++ b/change/@fluentui-react-native-link-b9049396-6b19-4751-9370-0b65d7d4f36c.json @@ -0,0 +1,7 @@ +{ + "type": "none", + "comment": "Fix text not wrapping", + "packageName": "@fluentui-react-native/link", + "email": "ayushsinghs@yahoo.in", + "dependentChangeType": "none" +} diff --git a/change/@fluentui-react-native-menu-4429ef8f-e6e0-4fda-898e-d1cac73b4e64.json b/change/@fluentui-react-native-menu-4429ef8f-e6e0-4fda-898e-d1cac73b4e64.json new file mode 100644 index 0000000000..a2e9d89054 --- /dev/null +++ b/change/@fluentui-react-native-menu-4429ef8f-e6e0-4fda-898e-d1cac73b4e64.json @@ -0,0 +1,7 @@ +{ + "type": "none", + "comment": "Fix text not wrapping", + "packageName": "@fluentui-react-native/menu", + "email": "ayushsinghs@yahoo.in", + "dependentChangeType": "none" +} diff --git a/change/@fluentui-react-native-notification-ad05670d-b703-43ab-808a-e9f140d89be1.json b/change/@fluentui-react-native-notification-ad05670d-b703-43ab-808a-e9f140d89be1.json new file mode 100644 index 0000000000..646875fa69 --- /dev/null +++ b/change/@fluentui-react-native-notification-ad05670d-b703-43ab-808a-e9f140d89be1.json @@ -0,0 +1,7 @@ +{ + "type": "none", + "comment": "Fix text not wrapping", + "packageName": "@fluentui-react-native/notification", + "email": "ayushsinghs@yahoo.in", + "dependentChangeType": "none" +} From 5f9b3f5e7c9c77cd1483c27f33bf04a95091803c Mon Sep 17 00:00:00 2001 From: Ayush Singh Date: Mon, 3 Apr 2023 17:28:00 +0530 Subject: [PATCH 11/13] Add fix for radio --- .../src/TestComponents/CheckboxV1/CheckboxV1Test.tsx | 2 +- packages/experimental/RadioGroup/src/Radio/Radio.styling.ts | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/apps/fluent-tester/src/TestComponents/CheckboxV1/CheckboxV1Test.tsx b/apps/fluent-tester/src/TestComponents/CheckboxV1/CheckboxV1Test.tsx index be580f531a..0e2ec58316 100644 --- a/apps/fluent-tester/src/TestComponents/CheckboxV1/CheckboxV1Test.tsx +++ b/apps/fluent-tester/src/TestComponents/CheckboxV1/CheckboxV1Test.tsx @@ -21,7 +21,7 @@ function onChangeUncontrolled(_e: InteractionEvent, isChecked: boolean) { const BasicCheckbox: React.FunctionComponent = () => { return ( - + diff --git a/packages/experimental/RadioGroup/src/Radio/Radio.styling.ts b/packages/experimental/RadioGroup/src/Radio/Radio.styling.ts index 62e622f77d..045ce9f2b8 100644 --- a/packages/experimental/RadioGroup/src/Radio/Radio.styling.ts +++ b/packages/experimental/RadioGroup/src/Radio/Radio.styling.ts @@ -80,6 +80,7 @@ export const stylingSettings: UseStylingOptions Date: Mon, 3 Apr 2023 17:29:43 +0530 Subject: [PATCH 12/13] Snaps update for rg --- .../__snapshots__/RadioExperimental.test.tsx.snap | 2 ++ .../RadioGroupExperimental.test.tsx.snap | 12 ++++++++++++ 2 files changed, 14 insertions(+) diff --git a/packages/experimental/RadioGroup/src/Radio/__snapshots__/RadioExperimental.test.tsx.snap b/packages/experimental/RadioGroup/src/Radio/__snapshots__/RadioExperimental.test.tsx.snap index 1fd0ca2cb8..1cf0d20ae3 100644 --- a/packages/experimental/RadioGroup/src/Radio/__snapshots__/RadioExperimental.test.tsx.snap +++ b/packages/experimental/RadioGroup/src/Radio/__snapshots__/RadioExperimental.test.tsx.snap @@ -118,6 +118,7 @@ exports[`Radio component tests Radio default 1`] = ` "borderStyle": "solid", "borderWidth": 2, "flexDirection": "column", + "flexShrink": 1, "marginLeft": 0, "marginRight": 0, "padding": undefined, @@ -272,6 +273,7 @@ exports[`Radio component tests Radio disabled 1`] = ` "borderStyle": "solid", "borderWidth": 2, "flexDirection": "column", + "flexShrink": 1, "marginLeft": 0, "marginRight": 0, "padding": undefined, diff --git a/packages/experimental/RadioGroup/src/RadioGroup/__snapshots__/RadioGroupExperimental.test.tsx.snap b/packages/experimental/RadioGroup/src/RadioGroup/__snapshots__/RadioGroupExperimental.test.tsx.snap index d580a60700..559b5e11a8 100644 --- a/packages/experimental/RadioGroup/src/RadioGroup/__snapshots__/RadioGroupExperimental.test.tsx.snap +++ b/packages/experimental/RadioGroup/src/RadioGroup/__snapshots__/RadioGroupExperimental.test.tsx.snap @@ -179,6 +179,7 @@ exports[`RadioGroup component tests Radio not direct child of radio group 1`] = "borderStyle": "solid", "borderWidth": 2, "flexDirection": "column", + "flexShrink": 1, "marginLeft": 0, "marginRight": 0, "padding": undefined, @@ -325,6 +326,7 @@ exports[`RadioGroup component tests Radio not direct child of radio group 1`] = "borderStyle": "solid", "borderWidth": 2, "flexDirection": "column", + "flexShrink": 1, "marginLeft": 0, "marginRight": 0, "padding": undefined, @@ -538,6 +540,7 @@ exports[`RadioGroup component tests RadioGroup default 1`] = ` "borderStyle": "solid", "borderWidth": 2, "flexDirection": "column", + "flexShrink": 1, "marginLeft": 0, "marginRight": 0, "padding": undefined, @@ -684,6 +687,7 @@ exports[`RadioGroup component tests RadioGroup default 1`] = ` "borderStyle": "solid", "borderWidth": 2, "flexDirection": "column", + "flexShrink": 1, "marginLeft": 0, "marginRight": 0, "padding": undefined, @@ -902,6 +906,7 @@ exports[`RadioGroup component tests RadioGroup disabled 1`] = ` "borderStyle": "solid", "borderWidth": 2, "flexDirection": "column", + "flexShrink": 1, "marginLeft": 0, "marginRight": 0, "padding": undefined, @@ -1053,6 +1058,7 @@ exports[`RadioGroup component tests RadioGroup disabled 1`] = ` "borderStyle": "solid", "borderWidth": 2, "flexDirection": "column", + "flexShrink": 1, "marginLeft": 0, "marginRight": 0, "padding": undefined, @@ -1267,6 +1273,7 @@ exports[`RadioGroup component tests RadioGroup horizontal 1`] = ` "borderStyle": "solid", "borderWidth": 2, "flexDirection": "column", + "flexShrink": 1, "marginLeft": 0, "marginRight": 0, "padding": undefined, @@ -1413,6 +1420,7 @@ exports[`RadioGroup component tests RadioGroup horizontal 1`] = ` "borderStyle": "solid", "borderWidth": 2, "flexDirection": "column", + "flexShrink": 1, "marginLeft": 0, "marginRight": 0, "padding": undefined, @@ -1627,6 +1635,7 @@ exports[`RadioGroup component tests RadioGroup horizontal-stacked 1`] = ` "borderStyle": "solid", "borderWidth": 2, "flexDirection": "column", + "flexShrink": 1, "marginLeft": 0, "marginRight": 0, "padding": 2, @@ -1773,6 +1782,7 @@ exports[`RadioGroup component tests RadioGroup horizontal-stacked 1`] = ` "borderStyle": "solid", "borderWidth": 2, "flexDirection": "column", + "flexShrink": 1, "marginLeft": 0, "marginRight": 0, "padding": 2, @@ -2005,6 +2015,7 @@ exports[`RadioGroup component tests RadioGroup required 1`] = ` "borderStyle": "solid", "borderWidth": 2, "flexDirection": "column", + "flexShrink": 1, "marginLeft": 0, "marginRight": 0, "padding": undefined, @@ -2151,6 +2162,7 @@ exports[`RadioGroup component tests RadioGroup required 1`] = ` "borderStyle": "solid", "borderWidth": 2, "flexDirection": "column", + "flexShrink": 1, "marginLeft": 0, "marginRight": 0, "padding": undefined, From d3ba9f4d934a5f73776ca5d63a36d4aa8051ed45 Mon Sep 17 00:00:00 2001 From: Ayush Singh Date: Mon, 3 Apr 2023 17:29:58 +0530 Subject: [PATCH 13/13] Change files --- ...native-tester-2600660f-25a6-4400-8d1e-4ed08ebe1af6.json | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 change/@fluentui-react-native-tester-2600660f-25a6-4400-8d1e-4ed08ebe1af6.json diff --git a/change/@fluentui-react-native-tester-2600660f-25a6-4400-8d1e-4ed08ebe1af6.json b/change/@fluentui-react-native-tester-2600660f-25a6-4400-8d1e-4ed08ebe1af6.json new file mode 100644 index 0000000000..0892589deb --- /dev/null +++ b/change/@fluentui-react-native-tester-2600660f-25a6-4400-8d1e-4ed08ebe1af6.json @@ -0,0 +1,7 @@ +{ + "type": "none", + "comment": "Add fix for radio", + "packageName": "@fluentui-react-native/tester", + "email": "ayushsinghs@yahoo.in", + "dependentChangeType": "none" +}