fix: add prefix to packages story titles #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrokirpa
added
documentation
mainframev
reviewed
Oct 23, 2024
| component: <%= componentName %>, | ||
| }; | ||
| } satisfies Meta<typeof <%= componentName %>>; |
There was a problem hiding this comment.
I know it's not completely within PR scope, but If this is becoming a standard for this repo, maybe it's worth to quickly align meta types in all packages? Wdyt?
There was a problem hiding this comment.
it's standard set by official storybook docs, maybe they have it as a rule within their plugin ( https://github.com/storybookjs/eslint-plugin-storybook - they dont 🥹 )
- please open issue on core repo to implement this enforcement within workspace eslint-rules, once done we can fast-forward to future eslint-plugin-react-components and use it here
There was a problem hiding this comment.
mainframev
approved these changes
Oct 23, 2024
Hotell
approved these changes
Oct 23, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docsproperty fromapps/docsite/project.json.Packages/format to ensure a consistent structure on the docsite.Before:
After:
