From 0d185dbd413515a7aaffeef6cce4760228b9e4ab Mon Sep 17 00:00:00 2001 From: Dmytro Kirpa Date: Wed, 23 Oct 2024 11:13:44 +0200 Subject: [PATCH 1/2] fix(docsite): add prefix to packages story titles --- apps/docsite/project.json | 2 -- .../index.stories.tsx.template | 7 +++-- .../generators/component/generator.spec.ts | 31 +++++++++++++++---- .../react-keytips/stories/index.stories.ts | 2 +- 4 files changed, 30 insertions(+), 12 deletions(-) diff --git a/apps/docsite/project.json b/apps/docsite/project.json index 24593521..f3e2658d 100644 --- a/apps/docsite/project.json +++ b/apps/docsite/project.json @@ -13,7 +13,6 @@ "options": { "port": 4400, "configDir": "apps/docsite/.storybook", - "docs": true, "docsMode": true }, "configurations": { @@ -28,7 +27,6 @@ "options": { "outputDir": "dist/storybook/docsite", "configDir": "apps/docsite/.storybook", - "docs": true, "docsMode": true }, "configurations": { diff --git a/packages/nx-plugin/src/generators/component/files/stories/__componentName__/index.stories.tsx.template b/packages/nx-plugin/src/generators/component/files/stories/__componentName__/index.stories.tsx.template index 2ad73d5e..633a3a0c 100644 --- a/packages/nx-plugin/src/generators/component/files/stories/__componentName__/index.stories.tsx.template +++ b/packages/nx-plugin/src/generators/component/files/stories/__componentName__/index.stories.tsx.template @@ -1,9 +1,10 @@ -import { Meta } from '@storybook/react'; +import type { Meta } from '@storybook/react'; import { <%= componentName %> } from '<%= npmScope %>/<%= name %>'; export { Default } from './Default.stories'; -const meta: Meta> = { +const meta = { + title: 'Packages/<%= name %>/<%= componentName %>', component: <%= componentName %>, -}; +} satisfies Meta>; export default meta; diff --git a/packages/nx-plugin/src/generators/component/generator.spec.ts b/packages/nx-plugin/src/generators/component/generator.spec.ts index 49589195..2bb973d5 100644 --- a/packages/nx-plugin/src/generators/component/generator.spec.ts +++ b/packages/nx-plugin/src/generators/component/generator.spec.ts @@ -14,7 +14,7 @@ describe('component generator', () => { let tree: Tree; const options: ComponentGeneratorSchema = { name: 'hello-world', - componentName: 'foo', + componentName: 'Foo', }; beforeEach(async () => { @@ -30,23 +30,42 @@ describe('component generator', () => { expect( tree.children( - joinPathFragments(config.sourceRoot as string, 'components/foo') + joinPathFragments(config.sourceRoot as string, 'components/Foo') ) ).toMatchInlineSnapshot(` [ - "foo.styles.ts", - "foo.test.tsx", - "foo.tsx", + "Foo.styles.ts", + "Foo.test.tsx", + "Foo.tsx", "index.ts", ] `); - expect(tree.children(joinPathFragments(config.root, 'stories/foo'))) + expect(tree.children(joinPathFragments(config.root, 'stories/Foo'))) .toMatchInlineSnapshot(` [ "Default.stories.tsx", "index.stories.tsx", ] `); + + const story = tree.read( + joinPathFragments(config.root, 'stories/Foo/index.stories.tsx'), + 'utf8' + ); + + expect(story).toMatchInlineSnapshot(` + "import type { Meta } from '@storybook/react'; + import { Foo } from '@fluentui-contrib/hello-world'; + export { Default } from './Default.stories'; + + const meta = { + title: 'Packages/hello-world/Foo', + component: Foo, + } satisfies Meta; + + export default meta; + " + `); }); }); diff --git a/packages/react-keytips/stories/index.stories.ts b/packages/react-keytips/stories/index.stories.ts index 974cefdf..6de268e2 100644 --- a/packages/react-keytips/stories/index.stories.ts +++ b/packages/react-keytips/stories/index.stories.ts @@ -6,7 +6,7 @@ export { DynamicStory as Dynamic } from './Dynamic.stories'; export { OverflowStory as Overflow } from './OverflowMenu.stories'; const meta = { - title: 'Keytips', + title: 'Packages/react-keytips', component: Keytips, } satisfies Meta; From e2972a3bedbf2b0691a93b3d05aeb77b73e43835 Mon Sep 17 00:00:00 2001 From: Dmytro Kirpa Date: Wed, 23 Oct 2024 11:15:12 +0200 Subject: [PATCH 2/2] Change files --- ...react-keytips-3771f4cd-49f4-48ff-a40a-30cb83e0610f.json | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 change/@fluentui-contrib-react-keytips-3771f4cd-49f4-48ff-a40a-30cb83e0610f.json diff --git a/change/@fluentui-contrib-react-keytips-3771f4cd-49f4-48ff-a40a-30cb83e0610f.json b/change/@fluentui-contrib-react-keytips-3771f4cd-49f4-48ff-a40a-30cb83e0610f.json new file mode 100644 index 00000000..e6baf61d --- /dev/null +++ b/change/@fluentui-contrib-react-keytips-3771f4cd-49f4-48ff-a40a-30cb83e0610f.json @@ -0,0 +1,7 @@ +{ + "type": "none", + "comment": "fix: make stories title consistent with other packages", + "packageName": "@fluentui-contrib/react-keytips", + "email": "kirpadv@gmail.com", + "dependentChangeType": "none" +}