Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding filters for test app and fixing dataset ids #118

Merged
merged 7 commits into from
Feb 4, 2025
Merged

Adding filters for test app and fixing dataset ids #118

merged 7 commits into from
Feb 4, 2025

Conversation

srmukher
Copy link
Contributor

@srmukher srmukher commented Jan 23, 2025 •
edited
Loading

Work item: https://uifabric.visualstudio.com/iss/_workitems/edit/12202

  1. Added Filters based on plot type and data type
  2. Added toggle for RTL mode
  3. Added Slider for changing width
  4. Persisted all filters, RTL mode and slider values
  5. Ensured the choices are marked with a tick in dropdown and shows the selected choice on reopening
  6. Enabled multi-selection for filters
  7. Fixed ids in localized data sets

image

@AtishayMsft AtishayMsft requested a review from krkshitij February 3, 2025 13:10
@srmukher srmukher force-pushed the users/srmukher/filters branch from a941613 to 51adef9 Compare February 3, 2025 14:50
@AtishayMsft AtishayMsft removed the request for review from krkshitij February 4, 2025 06:17
@srmukher srmukher merged commit 4cd4490 into main Feb 4, 2025
2 checks passed
@srmukher srmukher deleted the users/srmukher/filters branch February 4, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AtishayMsft AtishayMsft AtishayMsft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srmukher @AtishayMsft