From 87b0cffc575a12beb8416a699b7f7bb9c169a6e8 Mon Sep 17 00:00:00 2001 From: srmukher Date: Thu, 2 Jan 2025 16:34:58 +0530 Subject: [PATCH 1/2] Fixes for test app crashes for 12 schema data --- apps/plotly_examples/package.json | 2 +- apps/plotly_examples/src/components/DeclarativeChart.tsx | 2 +- apps/plotly_examples/src/data/data_085_Healthcare.json | 2 +- apps/plotly_examples/src/data/data_103_Automobile.json | 2 +- apps/plotly_examples/src/data/data_107_Hospitality.json | 2 +- apps/plotly_examples/yarn.lock | 8 ++++---- 6 files changed, 9 insertions(+), 9 deletions(-) diff --git a/apps/plotly_examples/package.json b/apps/plotly_examples/package.json index 8316eeea28..fa41f7d501 100644 --- a/apps/plotly_examples/package.json +++ b/apps/plotly_examples/package.json @@ -3,7 +3,7 @@ "version": "1.0.0", "private": true, "dependencies": { - "@fluentui/react-charting": "^5.23.34", + "@fluentui/react-charting": "^5.23.36", "@fluentui/react-portal-compat": "9.0.176", "@fluentui/react-components": "^9.21.0", "@types/d3-color": "^3.1.1", diff --git a/apps/plotly_examples/src/components/DeclarativeChart.tsx b/apps/plotly_examples/src/components/DeclarativeChart.tsx index 042fa0cfbe..bc639abcce 100644 --- a/apps/plotly_examples/src/components/DeclarativeChart.tsx +++ b/apps/plotly_examples/src/components/DeclarativeChart.tsx @@ -155,7 +155,7 @@ export class DeclarativeChartBasicExample extends React.Component<{}, IDeclarati


- {selectedSchema.layout.title} + {typeof selectedSchema.layout.title === 'string' ? selectedSchema.layout.title : typeof selectedSchema.layout.title.text === 'string' ? selectedSchema.layout.title.text : JSON.stringify(selectedSchema.layout.title)}

diff --git a/apps/plotly_examples/src/data/data_085_Healthcare.json b/apps/plotly_examples/src/data/data_085_Healthcare.json index 0edee9dd07..816acf1d5f 100644 --- a/apps/plotly_examples/src/data/data_085_Healthcare.json +++ b/apps/plotly_examples/src/data/data_085_Healthcare.json @@ -1,7 +1,7 @@ { "data": [ { - "type": "line", + "type": "scatter", "x": [ "2020 Q1", "2020 Q2", diff --git a/apps/plotly_examples/src/data/data_103_Automobile.json b/apps/plotly_examples/src/data/data_103_Automobile.json index 6e38b75d7f..3ef4c6f36e 100644 --- a/apps/plotly_examples/src/data/data_103_Automobile.json +++ b/apps/plotly_examples/src/data/data_103_Automobile.json @@ -1,7 +1,7 @@ { "data": [ { - "type": "line", + "type": "scatter", "x": [ "2023-01-01", "2023-01-02", diff --git a/apps/plotly_examples/src/data/data_107_Hospitality.json b/apps/plotly_examples/src/data/data_107_Hospitality.json index e68bb18eee..d5b6f5a08b 100644 --- a/apps/plotly_examples/src/data/data_107_Hospitality.json +++ b/apps/plotly_examples/src/data/data_107_Hospitality.json @@ -1,7 +1,7 @@ { "data": [ { - "type": "line", + "type": "scatter", "x": [ "Q1", "Q2", diff --git a/apps/plotly_examples/yarn.lock b/apps/plotly_examples/yarn.lock index dd79ee6a24..27d45abccb 100644 --- a/apps/plotly_examples/yarn.lock +++ b/apps/plotly_examples/yarn.lock @@ -1463,10 +1463,10 @@ embla-carousel-autoplay "^8.5.1" embla-carousel-fade "^8.5.1" -"@fluentui/react-charting@^5.23.34": - version "5.23.34" - resolved "https://registry.yarnpkg.com/@fluentui/react-charting/-/react-charting-5.23.34.tgz#6be296a1dada579ec9cffb6fd14c830ce4980dd0" - integrity sha512-661+lS/fGWBEJHxFZelOFWNh0dvDhgv/eHosaRVfbPe0w9ajfPwoUiINztz9+oTrq8i7vDvEwWAOCGH3BP34MA== +"@fluentui/react-charting@^5.23.36": + version "5.23.36" + resolved "https://registry.yarnpkg.com/@fluentui/react-charting/-/react-charting-5.23.36.tgz#ea6ee27af24d791907f9351143fbf1fda68e5872" + integrity sha512-ZP47OKJXmX3qnYtvi5TJZE3XGdc9Q31sc0/MxedhRGmLqWy0W+upFc2f5q2I61wk3/+M23FS/KioS0F4duhyiQ== dependencies: "@fluentui/react-focus" "^8.9.20" "@fluentui/set-version" "^8.2.23" From eade7df2ab9c75c27a3f38358e94167d622ef8ed Mon Sep 17 00:00:00 2001 From: srmukher Date: Mon, 6 Jan 2025 20:45:33 +0530 Subject: [PATCH 2/2] Keeping the schema type same which will be handled by default type --- apps/plotly_examples/src/data/data_085_Healthcare.json | 2 +- apps/plotly_examples/src/data/data_103_Automobile.json | 2 +- apps/plotly_examples/src/data/data_107_Hospitality.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/plotly_examples/src/data/data_085_Healthcare.json b/apps/plotly_examples/src/data/data_085_Healthcare.json index 816acf1d5f..0edee9dd07 100644 --- a/apps/plotly_examples/src/data/data_085_Healthcare.json +++ b/apps/plotly_examples/src/data/data_085_Healthcare.json @@ -1,7 +1,7 @@ { "data": [ { - "type": "scatter", + "type": "line", "x": [ "2020 Q1", "2020 Q2", diff --git a/apps/plotly_examples/src/data/data_103_Automobile.json b/apps/plotly_examples/src/data/data_103_Automobile.json index 3ef4c6f36e..6e38b75d7f 100644 --- a/apps/plotly_examples/src/data/data_103_Automobile.json +++ b/apps/plotly_examples/src/data/data_103_Automobile.json @@ -1,7 +1,7 @@ { "data": [ { - "type": "scatter", + "type": "line", "x": [ "2023-01-01", "2023-01-02", diff --git a/apps/plotly_examples/src/data/data_107_Hospitality.json b/apps/plotly_examples/src/data/data_107_Hospitality.json index d5b6f5a08b..e68bb18eee 100644 --- a/apps/plotly_examples/src/data/data_107_Hospitality.json +++ b/apps/plotly_examples/src/data/data_107_Hospitality.json @@ -1,7 +1,7 @@ { "data": [ { - "type": "scatter", + "type": "line", "x": [ "Q1", "Q2",