Skip to content

Commit 9941a1e

Browse files
AtishayMsftatisjai
andauthored
Establish baseline for 252 test schemas (#115)
Co-authored-by: Atishay Jain (from Dev Box) <[email protected]>
1 parent 355750f commit 9941a1e

File tree

127 files changed

+6
-5
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

127 files changed

+6
-5
lines changed

apps/plotly_examples/src/components/DeclarativeChart.tsx

+5-4
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ const DeclarativeChartBasicExample: React.FC<IDeclarativeChartProps> = () => {
104104
const layout_with_theme = { ...layout, plot_bgcolor: bgcolor, paper_bgcolor: bgcolor, font: fontColor };
105105
const plotlySchema = { data, layout: layout_with_theme, selectedLegends: lastKnownValidLegends };
106106
const inputSchema: Schema = { plotlySchema };
107+
const chartTitle = typeof layout?.title === 'string' ? layout.title : layout?.title?.text ?? '';
107108
return (
108109
<div key={uniqueKey}>
109110
<Subtitle1 align="center" style={{marginLeft:'30%'}}>Declarative chart from fluent</Subtitle1>
@@ -130,13 +131,13 @@ const DeclarativeChartBasicExample: React.FC<IDeclarativeChartProps> = () => {
130131
Download as Image
131132
</button>
132133
<div data-testid="chart-container" >
133-
<br />
134-
<br />
135-
<Subtitle2>{selectedSchema.layout.title}</Subtitle2>
136-
<Divider/>
137134
<br />
138135
<br />
139136
<ErrorBoundary>
137+
<Subtitle2>{chartTitle}</Subtitle2>
138+
<Divider/>
139+
<br />
140+
<br />
140141
<DeclarativeChart
141142
chartSchema={inputSchema}
142143
onSchemaChange={_handleChartSchemaChanged}

apps/plotly_examples/tests/DeclarativeChart.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { test, expect, Locator } from '@playwright/test';
22
import * as dotenv from 'dotenv';
33

4-
const chartsListWithErrors = [33, 84, 87, 90, 91, 92, 98, 99, 100, 101, 167,168, 169, 170, 182, 183, 184, 185, 188, 189, 190, 191, 194, 195];
4+
const chartsListWithErrors = [];
55
var totalChartExamplesCount = 252;
66

77
test.beforeEach( async ({ page }) => {

0 commit comments

Comments
 (0)