You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardexpand all lines: ios/CONTRIBUTING.md
+5-5
Original file line number
Diff line number
Diff line change
@@ -8,11 +8,11 @@ To build and run the demo app follow these steps:
8
8
- Clone the [FluentUI](https://github.com/microsoft/fluentui-apple) repository.
9
9
- Open `ios/FluentUI.xcworkspace` in Xcode.
10
10
- In the Xcode scheme menu choose `Demo.development` and choose an iOS Simulator(or Device if you have your own device provisioning profile) to deploy to.
11
-
- Make sure Swift Package Manager has download 2 dependencies(appcenter-sdk-apple and PLCrashReporter) for demo app.
11
+
- Make sure Swift Package Manager has downloaded 2 dependencies(AppCenter and PLCrashReporter) for demo app.
12
12
- Build and Run the demo app
13
13
14
14
## Adding a new component
15
-
- Create a new folder of the Control name (ex. Foo) under under [FluentUI](FluentUI)
15
+
- Create a new folder of the Control name (ex. Foo) under [FluentUI](FluentUI)
16
16
- Create a new swift file. (ex. Foo.swift)
17
17
- Add Foo.swift in Fluent xcode project (All the files are in alphabetical order)
18
18
- Make sure your file is under FluentUILib target
@@ -23,11 +23,11 @@ To build and run the demo app follow these steps:
23
23
- Add a new cocopod subspec in [MicrosoftFluentUI.podspec](https://github.com/microsoft/fluentui-apple/blob/main/MicrosoftFluentUI.podspec) with required dependencies. "s.subspec 'Foo_ios' do |foo_ios|"
24
24
- Verify by "pod spec lint" For more info on [cocoapod](https://cocoapods.org)
25
25
- Build and Run
26
-
- Make sure no warnings and errors. Test your components!
27
-
- Add documentation for your new class and especially for public apis
26
+
- Make sure there are no warnings and errors. Test your components!
27
+
- Add documentation for your new class and especially for public APIs
28
28
- Add Unit Test for FluentUITests framework
29
29
30
30
## Checklist before creating a pull request
31
-
Fill out all the information in your [PR description](https://github.com/microsoft/fluentui-apple/blob/main/.github/PULL_REQUEST_TEMPLATE.md#pull-request-checklist)
31
+
Fill out all the information in your [PR description](https://github.com/microsoft/fluentui-apple/blob/main/.github/PULL_REQUEST_TEMPLATE.md#pull-request-checklist).
32
32
33
33
Once your pull request has been approved by @microsoft/fluentui-native team, if you have the write access you can squash-merge your changes or @microsoft/fluentui-native team member will merge it for you.
0 commit comments