Skip to content

Commit 3b2bb1a

Browse files
committed
Improve iOS contributing guide
1 parent 3053e63 commit 3b2bb1a

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

ios/CONTRIBUTING.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ To build and run the demo app follow these steps:
88
- Clone the [FluentUI](https://github.com/microsoft/fluentui-apple) repository.
99
- Open `ios/FluentUI.xcworkspace` in Xcode.
1010
- In the Xcode scheme menu choose `Demo.development` and choose an iOS Simulator(or Device if you have your own device provisioning profile) to deploy to.
11-
- Make sure Swift Package Manager has download 2 dependencies(appcenter-sdk-apple and PLCrashReporter) for demo app.
11+
- Make sure Swift Package Manager has downloaded 2 dependencies(AppCenter and PLCrashReporter) for demo app.
1212
- Build and Run the demo app
1313

1414
## Adding a new component
15-
- Create a new folder of the Control name (ex. Foo) under under [FluentUI](FluentUI)
15+
- Create a new folder of the Control name (ex. Foo) under [FluentUI](FluentUI)
1616
- Create a new swift file. (ex. Foo.swift)
1717
- Add Foo.swift in Fluent xcode project (All the files are in alphabetical order)
1818
- Make sure your file is under FluentUILib target
@@ -23,11 +23,11 @@ To build and run the demo app follow these steps:
2323
- Add a new cocopod subspec in [MicrosoftFluentUI.podspec](https://github.com/microsoft/fluentui-apple/blob/main/MicrosoftFluentUI.podspec) with required dependencies. "s.subspec 'Foo_ios' do |foo_ios|"
2424
- Verify by "pod spec lint" For more info on [cocoapod](https://cocoapods.org)
2525
- Build and Run
26-
- Make sure no warnings and errors. Test your components!
27-
- Add documentation for your new class and especially for public apis
26+
- Make sure there are no warnings and errors. Test your components!
27+
- Add documentation for your new class and especially for public APIs
2828
- Add Unit Test for FluentUITests framework
2929

3030
## Checklist before creating a pull request
31-
Fill out all the information in your [PR description](https://github.com/microsoft/fluentui-apple/blob/main/.github/PULL_REQUEST_TEMPLATE.md#pull-request-checklist)
31+
Fill out all the information in your [PR description](https://github.com/microsoft/fluentui-apple/blob/main/.github/PULL_REQUEST_TEMPLATE.md#pull-request-checklist).
3232

3333
Once your pull request has been approved by @microsoft/fluentui-native team, if you have the write access you can squash-merge your changes or @microsoft/fluentui-native team member will merge it for you.

0 commit comments

Comments
 (0)