Cannot read properties of undefined (reading 'dispose')

[muji-wyh]

🐛 Bug Report

💻 Repro or Code Sample

at Edge's new tab page, we got lots of Cannot read properties of undefined (reading 'dispose') error messages in our log

{
	"stack": "TypeError: Cannot read properties of undefined (reading 'dispose')\n    
    at v.refreshAllViews 
    at v.handleChange 
    a......",
}

🤔 Expected Behavior

don't throw this exception

😯 Current Behavior

💁 Possible Solution

why not use "?.dispose" here?

fast-element/templating/repeat.js

    refreshAllViews(templateChanged = false) {
        //
        if (viewsLength === 0) {
           //
        }
        else {
            //
            for (i = 0, itemsLength = removed.length; i < itemsLength; ++i) {
                removed[i].dispose();
                // ^^^^^^^^^^^
            }
        }
    }

🔦 Context

🌍 Your Environment

Edge Browser, new tab page

[KingOfTac]

@muji-wyh Could you provide some additional environment information and possibly a minimum repro in a stackblitz? Things like tsconfig settings (if any), version of fast-element, etc.

[muji-wyh]

@KingOfTac

fast-element version: fixed 1.13.0

tsconfig

{
    "compilerOptions": {
        "forceConsistentCasingInFileNames": false,
        "useDefineForClassFields": false,
        "moduleResolution": "node",
        "module": "esnext",
        "target": "esnext",
        "declaration": true,
        "declarationMap": true,
        "esModuleInterop": true,
        "jsx": "react",
        "outDir": "./dist",
        "rootDir": "./src",
        "lib": [
            "dom",
            "es2015",
            "es2016",
            "es2019",
            "es2018.promise",
            "ES2020.Promise",
            "ES2021.String",
            "es2021.Promise"
        ],
        "composite": true,
        "resolveJsonModule": true,
        "sourceMap": true,
        "allowSyntheticDefaultImports": true,
        "noEmitHelpers": true,
        "importHelpers": true,
        "experimentalDecorators": true,
        "strict": true,
        "skipLibCheck": true,
        "preserveConstEnums": true,
        "plugins": [
            {
                "transform": "transform-minify-literals"
            },
            {
                "name": "typescript-plugin-css-modules"
            }
        ]
    },
    "watchOptions": {
        "watchFile": "fixedPollingInterval",
        "watchDirectory": "fixedpollinginterval",
        "fallbackPolling": "fixedchunksize",
        "excludeDirectories": [
            "**/node_modules",
            "**/dist",
            "build",
            "configs",
            "docs",
            "statics"
        ],
        "excludeFiles": [
            "**/*.json"
        ]
    },
    "files": [
        "./custom.d.ts"
    ],
    "include": [
        "src/**/*",
        "src/**/*.json"
    ],
    "exclude": [
        "**/node_modules/**",
        "**/Example*.data.ts*",
        "**/*.spec.ts",
        "**/*.spec.tsx",
        "**/mock-data/**",
    ],
}

[janechu]

@muji-wyh we are currently on @microsoft/[email protected], we are not accepting updates to v1 at this time, can you confirm the problem and a stackblitz repro using 2.0.1?

[muji-wyh]

@janechu It's hard to update from v1 to v2. When can you take a look at / fix this issue?