Skip to content

Commit 31d6a36

Browse files
authored
Minor change to make latest version of ESLint pass (#1048)
### Motivation and Context The newer ESLint is better and now complains about unneeded non-null operators (!) ### Description Remove the now-superfluous instances of '!' ### Contribution Checklist - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone :smile
1 parent 33d2eba commit 31d6a36

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

webapp/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
"prettier": "^3.3.2",
4444
"react-scripts": "^5.0.1",
4545
"serve": "^14.2.3",
46-
"typescript": "5.4.5"
46+
"typescript": "5.5.3"
4747
},
4848
"browserslist": {
4949
"production": [

webapp/src/components/chat/chat-list/ChatList.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,8 @@ export const ChatList: FC = () => {
111111
if (conversations[b].lastUpdatedTimestamp === undefined) {
112112
return -1;
113113
}
114-
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
115-
return conversations[a].lastUpdatedTimestamp! - conversations[b].lastUpdatedTimestamp!;
114+
115+
return conversations[a].lastUpdatedTimestamp - conversations[b].lastUpdatedTimestamp;
116116
});
117117

118118
// Add conversations to sortedConversations in the order of sortedIds.

webapp/yarn.lock

+4-4
Original file line numberDiff line numberDiff line change
@@ -11576,10 +11576,10 @@ typedarray-to-buffer@^3.1.5:
1157611576
dependencies:
1157711577
is-typedarray "^1.0.0"
1157811578

11579-
typescript@5.4.5:
11580-
version "5.4.5"
11581-
resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.4.5.tgz#42ccef2c571fdbd0f6718b1d1f5e6e5ef006f611"
11582-
integrity sha512-vcI4UpRgg81oIRUFwR0WSIHKt11nJ7SAVlYNIu+QpqeyXP+gpQJy/Z4+F0aGxSE4MqwjyXvW/TzgkLAx2AGHwQ==
11579+
typescript@5.5.3:
11580+
version "5.5.3"
11581+
resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.5.3.tgz#e1b0a3c394190838a0b168e771b0ad56a0af0faa"
11582+
integrity sha512-/hreyEujaB0w76zKo6717l3L0o/qEUtRgdvUBvlkhoWeOVMjMuHNHk0BRBzikzuGDqNmPQbg5ifMEqsHLiIUcQ==
1158311583

1158411584
unbox-primitive@^1.0.2:
1158511585
version "1.0.2"

0 commit comments

Comments
 (0)